Last Comment Bug 714256 - Remove nsTransactionManager::Lock()/Unlock()
: Remove nsTransactionManager::Lock()/Unlock()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: 10 Branch
: x86_64 Linux
: -- normal (vote)
: mozilla12
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-30 04:19 PST by Olli Pettay [:smaug]
Modified: 2012-01-01 21:10 PST (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (16.93 KB, patch)
2011-12-30 14:55 PST, :Ehsan Akhgari
roc: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2011-12-30 04:19:31 PST

    
Comment 1 :Ehsan Akhgari 2011-12-30 10:35:46 PST
No editor consumer accesses this object from multiple threads.  I'm not sure about places though...
Comment 2 Olli Pettay [:smaug] 2011-12-30 11:47:30 PST
The object is cycle collectable, so it would crash immediately if used in non-main-thread.
Comment 3 Marco Bonardo [::mak] 2011-12-30 13:55:46 PST
(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> No editor consumer accesses this object from multiple threads.  I'm not sure
> about places though...

Places only uses the transaction manager from js in the ui thread.
Comment 4 :Ehsan Akhgari 2011-12-30 14:55:51 PST
Created attachment 585058 [details] [diff] [review]
Patch (v1)
Comment 5 Mozilla RelEng Bot 2011-12-30 21:50:33 PST
Try run for 6355fe761f05 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6355fe761f05
Results (out of 206 total builds):
    exception: 1
    success: 183
    warnings: 22
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-6355fe761f05
 Timed out after 06 hours without completing.
Comment 7 Phil Ringnalda (:philor) 2012-01-01 21:10:32 PST
https://hg.mozilla.org/mozilla-central/rev/a4a07b81ad67

Note You need to log in before you can comment on or make changes to this bug.