The default bug view has changed. See this FAQ.

Remove nsTransactionManager::Lock()/Unlock()

RESOLVED FIXED in mozilla12

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: Ehsan)

Tracking

10 Branch
mozilla12
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
No editor consumer accesses this object from multiple threads.  I'm not sure about places though...
The object is cycle collectable, so it would crash immediately if used in non-main-thread.
(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> No editor consumer accesses this object from multiple threads.  I'm not sure
> about places though...

Places only uses the transaction manager from js in the ui thread.
(Assignee)

Comment 4

5 years ago
Created attachment 585058 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #585058 - Flags: review?(roc)
Attachment #585058 - Flags: review?(roc) → review+

Comment 5

5 years ago
Try run for 6355fe761f05 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6355fe761f05
Results (out of 206 total builds):
    exception: 1
    success: 183
    warnings: 22
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-6355fe761f05
 Timed out after 06 hours without completing.
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4a07b81ad67
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/a4a07b81ad67
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.