Closed Bug 714256 Opened 14 years ago Closed 14 years ago

Remove nsTransactionManager::Lock()/Unlock()

Categories

(Core :: DOM: Editor, defect)

10 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: smaug, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

No description provided.
No editor consumer accesses this object from multiple threads. I'm not sure about places though...
The object is cycle collectable, so it would crash immediately if used in non-main-thread.
(In reply to Ehsan Akhgari [:ehsan] from comment #1) > No editor consumer accesses this object from multiple threads. I'm not sure > about places though... Places only uses the transaction manager from js in the ui thread.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #585058 - Flags: review?(roc)
Try run for 6355fe761f05 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=6355fe761f05 Results (out of 206 total builds): exception: 1 success: 183 warnings: 22 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-6355fe761f05 Timed out after 06 hours without completing.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: