The default bug view has changed. See this FAQ.

Desktop icon on Tools/Options panel disappears if choosing to 'Save files to' Desktop

VERIFIED FIXED in Firefox 12

Status

()

Firefox
Preferences
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: pauly, Assigned: Gavin)

Tracking

({regression})

10 Branch
Firefox 12
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa!])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 584960 [details]
no desktop icon

Last good nightly: 2011-03-25
First bad nightly: 2011-03-26

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e11c2f95f781&tochan
ge=bf68a4a3ef6a

Reproducible: always
Steps to reproduce:
1. Launch Firefox
2. Go to Tools/Options/General
3. Choose to save files to desktop and then click OK
4. Go back to Tools/Options/General

Actual results:
Desktop icon disappears.

Expected results:
Desktop icon should be displayed.

Notes:
The issue is reproducible on all platforms.
Screenshot is attached.
Definitely a regression, though an old one.
Keywords: regression
Curiously, this only seems to happen with the Desktop folder; no other folder seems to reproduce it.
The fix for bug 474718 seems to be a likely culprit.
Whiteboard: [10b2]
Indeed, the patch for bug 474718 removed a variable ("desk") that was used later in the function... oops.
Created attachment 588783 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #588783 - Flags: review?(jwein)
Blocks: 474718
Comment on attachment 588783 [details] [diff] [review]
patch

Review of attachment 588783 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I applied this patch and tested it out too.

Unrelated to this bug, but I noticed that the dialog accepted a Library as a folder destination, but after choosing Select Folder the chosen Library didn't appear as the new download destination. It's probably because a Library is basically by-design read-only, but it's odd that it is allowed to be selected as a folder.
Attachment #588783 - Flags: review?(jwein) → review+
(In reply to Jared Wein [:jwein and :jaws] from comment #6)
> Unrelated to this bug, but I noticed that the dialog accepted a Library as a
> folder destination, but after choosing Select Folder the chosen Library
> didn't appear as the new download destination. It's probably because a
> Library is basically by-design read-only, but it's odd that it is allowed to
> be selected as a folder.

Filed bug 718374 for this.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ae60977feff
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/8ae60977feff
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [10b2] → [10b2][qa+]
(Reporter)

Comment 10

5 years ago
The issue is reproducible on latest Nightly 12.0a1 (2012-01-18) on all platforms.
Paul: are you suggesting the fix didn't work? I can't reproduce the bug using the latest Mac Nightly, following the steps in comment 0.
(In reply to Paul Silaghi [QA] from comment #10)
> The issue is reproducible on latest Nightly 12.0a1 (2012-01-18) on all
> platforms.

The patch was merged to mozilla-central on 1-18, so the nightly build on 1-18 likely didn't include this patch.
(Reporter)

Comment 13

5 years ago
The issue is not reproducible on:
Mozilla/5.0 (Windows NT 5.1; rv:12.0a1) Gecko/20120129 Firefox/12.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0a1) Gecko/20120129 Firefox/12.0a1
Mozilla/5.0 (X11; Linux x86_64; rv:12.0a1) Gecko/20120130 Firefox/12.0a1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120129 Firefox/12.0a1

Setting the resolution to verified fixed.
Status: RESOLVED → VERIFIED
Whiteboard: [10b2][qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.