714272 - Desktop icon on Tools/Options panel disappears if choosing to 'Save files to' Desktop

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Paul Silaghi, QA [:pauly]]

Attachment: no desktop icon

Last good nightly: 2011-03-25
First bad nightly: 2011-03-26

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e11c2f95f781&tochan
ge=bf68a4a3ef6a

Reproducible: always
Steps to reproduce:
1. Launch Firefox
2. Go to Tools/Options/General
3. Choose to save files to desktop and then click OK
4. Go back to Tools/Options/General

Actual results:
Desktop icon disappears.

Expected results:
Desktop icon should be displayed.

Notes:
The issue is reproducible on all platforms.
Screenshot is attached.

Comment 1

[u279076]

Definitely a regression, though an old one.

Comment 2

[u279076]

Curiously, this only seems to happen with the Desktop folder; no other folder seems to reproduce it.

Comment 3

[u279076]

The fix for bug 474718 seems to be a likely culprit.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Indeed, the patch for bug 474718 removed a variable ("desk") that was used later in the function... oops.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 588783 [details] [diff] [review]
patch

Review of attachment 588783 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I applied this patch and tested it out too.

Unrelated to this bug, but I noticed that the dialog accepted a Library as a folder destination, but after choosing Select Folder the chosen Library didn't appear as the new download destination. It's probably because a Library is basically by-design read-only, but it's odd that it is allowed to be selected as a folder.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jwein and :jaws] from comment #6)
> Unrelated to this bug, but I noticed that the dialog accepted a Library as a
> folder destination, but after choosing Select Folder the chosen Library
> didn't appear as the new download destination. It's probably because a
> Library is basically by-design read-only, but it's odd that it is allowed to
> be selected as a folder.

Filed bug 718374 for this.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ae60977feff

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8ae60977feff

Comment 10

[Paul Silaghi, QA [:pauly]]

The issue is reproducible on latest Nightly 12.0a1 (2012-01-18) on all platforms.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Paul: are you suggesting the fix didn't work? I can't reproduce the bug using the latest Mac Nightly, following the steps in comment 0.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Paul Silaghi [QA] from comment #10)
> The issue is reproducible on latest Nightly 12.0a1 (2012-01-18) on all
> platforms.

The patch was merged to mozilla-central on 1-18, so the nightly build on 1-18 likely didn't include this patch.

Comment 13

[Paul Silaghi, QA [:pauly]]

The issue is not reproducible on:
Mozilla/5.0 (Windows NT 5.1; rv:12.0a1) Gecko/20120129 Firefox/12.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0a1) Gecko/20120129 Firefox/12.0a1
Mozilla/5.0 (X11; Linux x86_64; rv:12.0a1) Gecko/20120130 Firefox/12.0a1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120129 Firefox/12.0a1

Setting the resolution to verified fixed.