Closed Bug 714285 Opened 8 years ago Closed 8 years ago

No context menu on long tap on inputs without type=text attribute

Categories

(Firefox for Android :: General, defect, P3)

11 Branch
ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
fennec 11+ ---

People

(Reporter: martijn.martijn, Assigned: mbrubeck)

References

()

Details

(Whiteboard: [has patch])

Attachments

(1 file)

See url, long tapping on the inputs on that page doesn't result in a context menu.
I guess because of the user-scalable=no meta tag, but I have no idea.
Assignee: nobody → wjohnston
Priority: -- → P3
Assignee: wjohnston → mbrubeck
tracking-fennec: --- → 11+
Attached patch patchSplinter Review
The selector is looking specifically for <input type="text">, so it does not match plain <input> elements.  This patch copies the code from XUL Fennec instead, which uses mozIsTextField(false).  (The "false" means "don't exclude password fields.")
Attachment #587792 - Flags: review?(wjohnston)
Status: NEW → ASSIGNED
Whiteboard: [has patch]
Summary: No context menu on long tap on inputs on this page (because of user-scalable: no?) → No context menu on long tap on inputs without type=text attribute
Comment on attachment 587792 [details] [diff] [review]
patch

Review of attachment 587792 [details] [diff] [review]:
-----------------------------------------------------------------

My fiendish plan to use selectors for everything is falling apart.
Attachment #587792 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa9cc1988191
Target Milestone: --- → Firefox 12
Version: unspecified → Firefox 11
Comment on attachment 587792 [details] [diff] [review]
patch

[Approval Request Comment]
Low-risk Android-only patch that fixes broken context menus on some form fields.  (Without the patch, it's impossible to display context menus for these elements.)
Attachment #587792 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/fa9cc1988191
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 587792 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #587792 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 717095
Verified fixed in today's trunk build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.