714285 - No context menu on long tap on inputs without type=text attribute

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Martijn Wargers (dead)]

See url, long tapping on the inputs on that page doesn't result in a context menu.
I guess because of the user-scalable=no meta tag, but I have no idea.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

The selector is looking specifically for <input type="text">, so it does not match plain <input> elements.  This patch copies the code from XUL Fennec instead, which uses mozIsTextField(false).  (The "false" means "don't exclude password fields.")

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 587792 [details] [diff] [review]
patch

Review of attachment 587792 [details] [diff] [review]:
-----------------------------------------------------------------

My fiendish plan to use selectors for everything is falling apart.

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa9cc1988191

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 587792 [details] [diff] [review]
patch

[Approval Request Comment]
Low-risk Android-only patch that fixes broken context menus on some form fields.  (Without the patch, it's impossible to display context menus for these elements.)

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/fa9cc1988191

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 587792 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/98d676705242

Comment 9

[Martijn Wargers (dead)]

Verified fixed in today's trunk build.