Closed Bug 714306 Opened 9 years ago Closed 9 years ago

Service handle leak in netwerk/base/src/nsAutodialWin.cpp

Categories

(Core :: Networking, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: bbondy, Assigned: bbondy)

Details

Attachments

(1 file, 1 obsolete file)

The calls to OpenSCManager and OpenServiceW in netwerk/base/src/nsAutodialWin.cpp return service handles.  Those handles should be closed but are never being closed.
Attached patch Leak fix. Patch v1. (obsolete) — Splinter Review
Service handles were not being closed on any return path.

I'll land this after bug 481815 lands which defines nsAutoServiceHandle (an RAII class for ensuring service handles are closed).
Attachment #584988 - Flags: review?(bsmith)
Just fixed whitespace.
Attachment #584988 - Attachment is obsolete: true
Attachment #584988 - Flags: review?(bsmith)
Attachment #584990 - Flags: review?(bsmith)
Attachment #584990 - Flags: review?(bsmith) → review?(cbiesinger)
Attachment #584990 - Flags: review?(cbiesinger) → review+
Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/1cc0885caf02
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/1cc0885caf02
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.