Closed
Bug 714332
Opened 14 years ago
Closed 14 years ago
Fix uint64 types usage in dom/workers and dom/base
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: gaston, Assigned: gaston)
References
Details
Attachments
(1 file, 1 obsolete file)
3.23 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Right now, m-c fails to build in dom/workers/WorkerPrivate.cpp :
dom/workers/WorkerPrivate.cpp:822: error: no matching function for call to 'JSAutoStructuredCloneBuffer::steal(uint64**, size_t*)'
../../dist/include/jsapi.h:4641: note: candidates are: void
JSAutoStructuredCloneBuffer::steal(uint64_t**, size_t*, uint32_t*) <near match>
dom/workers/WorkerPrivate.cpp:833: error: no matching function for call to 'JSAutoStructuredCloneBuffer::adopt(uint64*&, size_t&)'
../../dist/include/jsapi.h:4634: note: candidates are: void
JSAutoStructuredCloneBuffer::adopt(uint64_t*, size_t, uint32_t) <near match>
dom/workers/WorkerPrivate.cpp:853: error: no matching function for call to 'JSAutoStructuredCloneBuffer::steal(uint64**, size_t*)'
../../dist/include/jsapi.h:4641: note: candidates are: void
JSAutoStructuredCloneBuffer::steal(uint64_t**, size_t*, uint32_t*) <near match>
using uint64_t* instead of uint64* for mData in class MessageEventRunnable fixes it.
It also fails in dom/base/nsStructuredCloneContainer.cpp :
dom/base/nsStructuredCloneContainer.cpp:96: error: invalid conversion from 'PRUint64*' to 'uint64_t*'
dom/base/nsStructuredCloneContainer.cpp:131: error: invalid conversion from 'PRUint64*' to 'uint64_t*
casting to uint64_t* instead of PRuint64* for both mallocs fixes it.
Assignee | ||
Comment 1•14 years ago
|
||
Forgot to add this is a fallowup of #649537 & #551225, last bugs touching that part of code, and i"ve pushed the proposed patch to https://tbpl.mozilla.org/?tree=Try&rev=53b50fdbc98a
Assignee: nobody → landry
Attachment #585008 -
Flags: review?(bent.mozilla)
Assignee | ||
Comment 2•14 years ago
|
||
Doh, i had a typo in patch (uint64_t vs uint64_t*), new patch & new tbpl push : https://tbpl.mozilla.org/?tree=Try&rev=8c00dd5daf8e
Attachment #585008 -
Attachment is obsolete: true
Attachment #585008 -
Flags: review?(bent.mozilla)
Attachment #585015 -
Flags: review?(bent.mozilla)
Assignee | ||
Comment 3•14 years ago
|
||
Some tests failed for strange reasons i can't explain, but all builds were fine with that patch.
Updated•14 years ago
|
Attachment #585015 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•