714342 - page-proxy-stack should be a <hbox> rather than a <stack>

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Dão Gottwald [:dao]]

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#539

page-proxy-stack contains only one element (page-proxy-favicon), there's nothing to be stacked. We should use a plain box element for this, not a stack element. We should however keep the "page-proxy-stack" id for backwards-compatibility with add-ons.

Comment 1

[Murali]

Hi, I would like to work on this bug. Can you please mentor me? This is my first bug. Thanks a lot!

Comment 2

[Dão Gottwald [:dao]]

Hi! Do you already have a copy of the source code? https://developer.mozilla.org/en/Mozilla_Source_Code_%28Mercurial%29 has some information on this.

Comment 3

[Murali]

I already got the source code from https://developer.mozilla.org/En/Simple_Firefox_build . Could you please tell me whether it is the same? Or should I follow the instructions from the link you provided? Thanks!

Comment 4

[Dão Gottwald [:dao]]

It's the same. You can now open browser/base/content/browser.xul in your editor, find the line containing '<stack id="page-proxy-stack"' and make this a "hbox" element instead of a "stack" element.

Comment 5

[Murali]

Attachment: page-proxy-stack made into a <hbox> element

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 590664 [details] [diff] [review]
page-proxy-stack made into a <hbox> element

>+              <hbox id="page-proxy-stack"
>                      onclick="PageProxyClickHandler(event);">

nit-pick: please adjust the second line's indentation so that the attributes line up again

Comment 7

[Murali]

Attachment: page-proxy-stack made into a <hbox> element (alignment fixed)

Alignment fixed...?

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 590665 [details] [diff] [review]
page-proxy-stack made into a <hbox> element (alignment fixed)

You seem to have modified the patch. Instead, you need to modify the source and generate a new patch.

Comment 9

[Murali]

Attachment: page-proxy-stack made into a <hbox> element

So sorry, I did not know it made a difference.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 590666 [details] [diff] [review]
page-proxy-stack made into a <hbox> element

Thanks!

Comment 11

[Murali]

Thank you so much for guiding me!! :)

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/79cb2db62a9b

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/79cb2db62a9b

Thank you for the patch! This will be in tomorrow's nightly. If you need any inspiration for things to fix next, pop on #developers @ irc.mozilla.org :-)