Note: There are a few cases of duplicates in user autocompletion which are being worked on.

page-proxy-stack should be a <hbox> rather than a <stack>

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Location Bar
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: Murali)

Tracking

Trunk
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=dao][lang=xul])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#539

page-proxy-stack contains only one element (page-proxy-favicon), there's nothing to be stacked. We should use a plain box element for this, not a stack element. We should however keep the "page-proxy-stack" id for backwards-compatibility with add-ons.
(Assignee)

Comment 1

6 years ago
Hi, I would like to work on this bug. Can you please mentor me? This is my first bug. Thanks a lot!
(Reporter)

Comment 2

6 years ago
Hi! Do you already have a copy of the source code? https://developer.mozilla.org/en/Mozilla_Source_Code_%28Mercurial%29 has some information on this.
(Assignee)

Comment 3

6 years ago
I already got the source code from https://developer.mozilla.org/En/Simple_Firefox_build . Could you please tell me whether it is the same? Or should I follow the instructions from the link you provided? Thanks!
(Reporter)

Comment 4

6 years ago
It's the same. You can now open browser/base/content/browser.xul in your editor, find the line containing '<stack id="page-proxy-stack"' and make this a "hbox" element instead of a "stack" element.
(Assignee)

Comment 5

6 years ago
Created attachment 590664 [details] [diff] [review]
page-proxy-stack made into a <hbox> element
(Reporter)

Comment 6

6 years ago
Comment on attachment 590664 [details] [diff] [review]
page-proxy-stack made into a <hbox> element

>+              <hbox id="page-proxy-stack"
>                      onclick="PageProxyClickHandler(event);">

nit-pick: please adjust the second line's indentation so that the attributes line up again
(Reporter)

Updated

6 years ago
Assignee: nobody → murali.sr92
(Assignee)

Comment 7

6 years ago
Created attachment 590665 [details] [diff] [review]
page-proxy-stack made into a <hbox> element (alignment fixed)

Alignment fixed...?
Attachment #590664 - Attachment is obsolete: true
(Reporter)

Comment 8

6 years ago
Comment on attachment 590665 [details] [diff] [review]
page-proxy-stack made into a <hbox> element (alignment fixed)

You seem to have modified the patch. Instead, you need to modify the source and generate a new patch.
(Assignee)

Comment 9

6 years ago
Created attachment 590666 [details] [diff] [review]
page-proxy-stack made into a <hbox> element

So sorry, I did not know it made a difference.
Attachment #590665 - Attachment is obsolete: true
(Reporter)

Comment 10

6 years ago
Comment on attachment 590666 [details] [diff] [review]
page-proxy-stack made into a <hbox> element

Thanks!
Attachment #590666 - Flags: review+
(Assignee)

Comment 11

6 years ago
Thank you so much for guiding me!! :)
(Reporter)

Comment 12

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/79cb2db62a9b
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/79cb2db62a9b

Thank you for the patch! This will be in tomorrow's nightly. If you need any inspiration for things to fix next, pop on #developers @ irc.mozilla.org :-)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.