Last Comment Bug 714347 - pymake: $(sort) should remove duplicates
: pymake: $(sort) should remove duplicates
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla12
Assigned To: Ted Mielczarek [:ted.mielczarek]
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
  Show dependency treegraph
Reported: 2011-12-30 13:25 PST by Ted Mielczarek [:ted.mielczarek]
Modified: 2012-01-04 07:47 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

pymake sort function should remove duplicates. (1.36 KB, patch)
2011-12-30 13:27 PST, Ted Mielczarek [:ted.mielczarek]
khuey: review+
Details | Diff | Splinter Review

Description User image Ted Mielczarek [:ted.mielczarek] 2011-12-30 13:25:39 PST
The GNU Make manual says:
"$(sort list)
    Sorts the words of list in lexical order, removing duplicate words. The output is a list of words separated by single spaces."
Comment 1 User image Ted Mielczarek [:ted.mielczarek] 2011-12-30 13:27:30 PST
Created attachment 585034 [details] [diff] [review]
pymake sort function should remove duplicates.

Pretty simple patch, all tests pass with this applied.
Comment 2 User image Ted Mielczarek [:ted.mielczarek] 2011-12-31 04:59:56 PST

I'll push to b-s soon.
Comment 3 User image Ted Mielczarek [:ted.mielczarek] 2012-01-03 10:15:10 PST
Comment 4 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-01-04 07:47:26 PST

Note You need to log in before you can comment on or make changes to this bug.