Last Comment Bug 714411 - Silence 294 warnings when building with clang due to -Wmismatched-tags
: Silence 294 warnings when building with clang due to -Wmismatched-tags
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
-- minor (vote)
: mozilla12
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
Depends on:
  Show dependency treegraph
Reported: 2011-12-30 20:18 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-01-01 21:04 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (1.28 KB, patch)
2011-12-30 20:18 PST, Jeff Walden [:Waldo] (remove +bmo to email)
dholbert: review+
Details | Diff | Splinter Review

Description User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-30 20:18:57 PST
Created attachment 585107 [details] [diff] [review]

We have no compunctions about modifying IPC code imported from Chromium, just so you're aware.
Comment 1 User image Daniel Holbert [:dholbert] 2011-12-30 20:32:03 PST
Comment on attachment 585107 [details] [diff] [review]

(I'm assuming you've verified that the underlying structures are indeed defined as structs instead of classes.)

I also don't have any ownership over /ipc, /gfx, or /content/canvas, but this change is trivial enough that I don't think it matters.

r=me!  Hooray for 294 fewer warnings. :)
Comment 2 User image Jeff Walden [:Waldo] (remove +bmo to email) 2012-01-01 16:54:15 PST

Yeah, I was pretty much looking for the rubber-stamp.  :-)
Comment 3 User image Phil Ringnalda (:philor) 2012-01-01 21:04:32 PST

Note You need to log in before you can comment on or make changes to this bug.