Closed
Bug 714411
Opened 14 years ago
Closed 14 years ago
Silence 294 warnings when building with clang due to -Wmismatched-tags
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
We have no compunctions about modifying IPC code imported from Chromium, just so you're aware.
Attachment #585107 -
Flags: review?(dholbert)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 585107 [details] [diff] [review]
Patch
(I'm assuming you've verified that the underlying structures are indeed defined as structs instead of classes.)
I also don't have any ownership over /ipc, /gfx, or /content/canvas, but this change is trivial enough that I don't think it matters.
r=me! Hooray for 294 fewer warnings. :)
|
|
||
Updated•14 years ago
|
Attachment #585107 -
Flags: review?(dholbert) → review+
|
|
||
Updated•14 years ago
|
Version: unspecified → Trunk
|
Assignee | |
Comment 2•14 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/68af7609e29f
Yeah, I was pretty much looking for the rubber-stamp. :-)
Target Milestone: --- → mozilla12
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•