714432 - Lightning not working on some Windows XP [Failed to load native module at path ...\calbasecomps.dll]

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

I have seen several reports stating that Lightning 1.1 doesn't work. Most of the reports seem to be on Windows XP and include the following errors:

Failed to load native module at path '[...]\extensions\{e2fda1a4-762b-4020-b5ad-a41df1933103}\components\calbasecomps.dll': (80004003) error 14001

Error: Components.classes['@mozilla.org/calendar/datetime;1'] is undefined
Source: chrome://calendar/content/calUtils.js Line: 78

Firefox had a similar problem, see Bug 713167. Maybe we need a similar fix.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Thanks for the link. This patch does what the Firefox patch does. I haven't actually tested it on windows, but it seems to compile and run on mac. Maybe you could take a look?

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 585199 [details] [diff] [review]
Fix - v1

>-USE_STATIC_LIBS = 1 # This links against the static CRT on Windows
> 
>+# Statically link the CRT on Windows if building against a XULrunner SDK
>+ifdef LIBXUL_SDK
>+USE_STATIC_LIBS = 1
>+endif

I don't think you need to do this as you're always going to be a shared library, so I'd say no to this change.

>+# Ensure that we don't embed a manifest referencing the CRT
>+EMBED_MANIFEST_AT =

This needs to come after rules.mk is included.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

As discussed on IRC, just the EMBED_MANIFEST_AT line, put at the end of the file. pushing in a minute.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central changeset e139a77f8bb1

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Backported to releases/comm-aurora changeset bfc2a749cd70

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Backported to releases/comm-beta changeset 318f73969038

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Backported to releases/comm-release changeset d6f17beb0a32 for Lightning 1.1.1

Comment 8

[Mark Banner (:standard8)]

I just verified this works for trunk builds on my Windows XP without MSVC redist files.

Comment 9

[Stefan Sitter [:ssitter]]

When trying to reproduce / verify this problem I noticed that vanilla Thunderbird has a similar problem. Thunderbird would not startup at all on my Windows XP system until after I installed the Microsoft Visual C++ 2005 Service Pack 1 Redistributable Package.

Comment 10

[Mark Banner (:standard8)]

(In reply to Stefan Sitter from comment #9)
> When trying to reproduce / verify this problem I noticed that vanilla
> Thunderbird has a similar problem. Thunderbird would not startup at all on
> my Windows XP system until after I installed the Microsoft Visual C++ 2005
> Service Pack 1 Redistributable Package.

As always, please specify your version. Problematic versions of Thunderbird would be 9.0 and 10.0b1. All other current branch versions should be fixed, if not please file a bug.