Closed Bug 714448 Opened 8 years ago Closed 8 years ago

Today pane closes when attempting to scroll message preview

Categories

(Calendar :: General, defect)

Lightning 1.0
x86_64
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: michael, Assigned: Paenglab)

Details

Attachments

(5 files)

I have lightning enabled showing my tasks in the bottom-right hand of the screen, beneath my calendar's upcoming events. This places the tasks directly to the right of the message preview.

The problem is that a significant portion of the message preview scrollbar is taken up by the "drag" area of the today pane. Starting from the today pane, on the right, there is,

  * One pixel that gives the double-arrow "resize" cursor
  * A large area with the hand cursor that allows resizing, but ALSO closes the today pane on a single click.
  * The rest of the scrollbar working normally, towards the left half.

I only see the problem when the cursor is to the left of an actual task, though. Along the bottom half of the task list (where there are no tasks), the cursor jumps right from the resize arrows to the normal pointer.

Hopefully the screenshots make this clear!
Michael, so you say clicking the drag area closes the today pane? This is strange. Are you sure you are not accidentally moving it to the right, causing it to collapse when its minimum width has been reached?


Richard, how is our theming here, is it the same as for Thunderbird?
The theming is the same as for TB. We have a overlap of 4px over the scrollbar. With normal wide scrollbars I would say this is no problem.

For me attachment 585140 [details] is weird. This shows the grippy functionality but on Windows the grippy is 0px * 0px. Is the screenshot from Windows or Linux?
Ah okay I checked under Linux and the grippy is 115px * 4px. I'll check under OSX and make a patch to remove the grippy.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Michael, so you say clicking the drag area closes the today pane? This is
> strange. Are you sure you are not accidentally moving it to the right,
> causing it to collapse when its minimum width has been reached?

I'm sure, it's easy to reproduce. If I single click, it closes the today pane. If I drag it around, it resizes. The usual result of this is that I'll accidentally mouse-down in the drag area, realize what I've done, and then have to resize the pane a little so that it doesn't close on me.
(In reply to Richard Marti [:paenglab] from comment #5)
> The theming is the same as for TB. We have a overlap of 4px over the
> scrollbar. With normal wide scrollbars I would say this is no problem.
> 
> For me attachment 585140 [details] is weird. This shows the grippy
> functionality but on Windows the grippy is 0px * 0px. Is the screenshot from
> Windows or Linux?

It's on Linux.

I previously stated that the hand only shows up to the left of a task; that's incorrect: it only occurs next to the *first* task, near the top of the list.

I get the regular resize left/right arrows further down the list, even next to a task.
This patch removes the grippy under Linux. Under OSX the grippy is also 0px wide and has no effect.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #588140 - Flags: review?(philipp)
Comment on attachment 588140 [details] [diff] [review]
Remove the grippy

r=philipp and approval for aurora
Attachment #588140 - Flags: review?(philipp) → review+
Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/b23090be53f4>
and to comm-aurora: <http://hg.mozilla.org/releases/comm-aurora/rev/d9df36db99a3>
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Thanks guys!
You need to log in before you can comment on or make changes to this bug.