714448 - Today pane closes when attempting to scroll message preview

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Michael Orlitzky]

Attachment: A screenshot showing the pointer over a task

I have lightning enabled showing my tasks in the bottom-right hand of the screen, beneath my calendar's upcoming events. This places the tasks directly to the right of the message preview.

The problem is that a significant portion of the message preview scrollbar is taken up by the "drag" area of the today pane. Starting from the today pane, on the right, there is,

  * One pixel that gives the double-arrow "resize" cursor
  * A large area with the hand cursor that allows resizing, but ALSO closes the today pane on a single click.
  * The rest of the scrollbar working normally, towards the left half.

I only see the problem when the cursor is to the left of an actual task, though. Along the bottom half of the task list (where there are no tasks), the cursor jumps right from the resize arrows to the normal pointer.

Hopefully the screenshots make this clear!

Comment 1

[Michael Orlitzky]

Attachment: The pointer over the resize area, to the far right of the scrollbar.

Comment 2

[Michael Orlitzky]

Attachment: The pointer slightly to the left of the resize arrows, clicking this closes the today pane!

Comment 3

[Michael Orlitzky]

Attachment: The pointer even further to the left, where you need to be to scroll the window.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Michael, so you say clicking the drag area closes the today pane? This is strange. Are you sure you are not accidentally moving it to the right, causing it to collapse when its minimum width has been reached?


Richard, how is our theming here, is it the same as for Thunderbird?

Comment 5

[Richard Marti (:Paenglab)]

The theming is the same as for TB. We have a overlap of 4px over the scrollbar. With normal wide scrollbars I would say this is no problem.

For me attachment 585140 [details] is weird. This shows the grippy functionality but on Windows the grippy is 0px * 0px. Is the screenshot from Windows or Linux?

Comment 6

[Richard Marti (:Paenglab)]

Ah okay I checked under Linux and the grippy is 115px * 4px. I'll check under OSX and make a patch to remove the grippy.

Comment 7

[Michael Orlitzky]

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Michael, so you say clicking the drag area closes the today pane? This is
> strange. Are you sure you are not accidentally moving it to the right,
> causing it to collapse when its minimum width has been reached?

I'm sure, it's easy to reproduce. If I single click, it closes the today pane. If I drag it around, it resizes. The usual result of this is that I'll accidentally mouse-down in the drag area, realize what I've done, and then have to resize the pane a little so that it doesn't close on me.

Comment 8

[Michael Orlitzky]

(In reply to Richard Marti [:paenglab] from comment #5)
> The theming is the same as for TB. We have a overlap of 4px over the
> scrollbar. With normal wide scrollbars I would say this is no problem.
> 
> For me attachment 585140 [details] is weird. This shows the grippy
> functionality but on Windows the grippy is 0px * 0px. Is the screenshot from
> Windows or Linux?

It's on Linux.

I previously stated that the hand only shows up to the left of a task; that's incorrect: it only occurs next to the *first* task, near the top of the list.

I get the regular resize left/right arrows further down the list, even next to a task.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Remove the grippy

This patch removes the grippy under Linux. Under OSX the grippy is also 0px wide and has no effect.

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 588140 [details] [diff] [review]
Remove the grippy

r=philipp and approval for aurora

Comment 11

[Richard Marti (:Paenglab)]

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/b23090be53f4>
and to comm-aurora: <http://hg.mozilla.org/releases/comm-aurora/rev/d9df36db99a3>

Comment 12

[Michael Orlitzky]

Thanks guys!