714449 - nsCacheService::SetDiskSmartSize_Locked uses preferences off the main thread

Status: RESOLVED WORKSFORME

(Core :: Networking: Cache, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

which is not allowed.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Michal, I am tentatively assigning this to you, since bug 714449 is assigned to you. Will the patch in bug 714449 solve this problem?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Brian Smith (:bsmith) from comment #1)
> Michal, I am tentatively assigning this to you, since bug 714449 is assigned
> to you. Will the patch in bug 714449 solve this problem?

Seems like circular reasoning :-P

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #2)
> (In reply to Brian Smith (:bsmith) from comment #1)
> > Michal, I am tentatively assigning this to you, since bug 714449 is assigned
> > to you. Will the patch in bug 714449 solve this problem?
> 
> Seems like circular reasoning :-P

Thanks Kyle. Take two: Michal, I am tentatively assigning this to you, since bug 707436 is assigned to you. Will the patch in bug 707436 solve this problem?

Comment 4

[Michal Novotny [:michal]]

No, that patch won't fix this. nsSetDiskSmartSizeCallback::Notify() will be called on the same thread as nsCacheService::CreateDiskDevice(), i.e. on cache IO thread in most cases. I'll change the patch in bug #707436 to fix this issue.

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

The check of the pref was removed in the patch for bug 707436.

http://hg.mozilla.org/mozilla-central/rev/461a7c923594#l1.334