Closed Bug 714449 Opened 12 years ago Closed 12 years ago

nsCacheService::SetDiskSmartSize_Locked uses preferences off the main thread

Categories

(Core :: Networking: Cache, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: khuey, Assigned: michal)

References

Details

Michal, I am tentatively assigning this to you, since bug 714449 is assigned to you. Will the patch in bug 714449 solve this problem?
Assignee: nobody → michal.novotny
(In reply to Brian Smith (:bsmith) from comment #1)
> Michal, I am tentatively assigning this to you, since bug 714449 is assigned
> to you. Will the patch in bug 714449 solve this problem?

Seems like circular reasoning :-P
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2)
> (In reply to Brian Smith (:bsmith) from comment #1)
> > Michal, I am tentatively assigning this to you, since bug 714449 is assigned
> > to you. Will the patch in bug 714449 solve this problem?
> 
> Seems like circular reasoning :-P

Thanks Kyle. Take two: Michal, I am tentatively assigning this to you, since bug 707436 is assigned to you. Will the patch in bug 707436 solve this problem?
No, that patch won't fix this. nsSetDiskSmartSizeCallback::Notify() will be called on the same thread as nsCacheService::CreateDiskDevice(), i.e. on cache IO thread in most cases. I'll change the patch in bug #707436 to fix this issue.
The check of the pref was removed in the patch for bug 707436.

http://hg.mozilla.org/mozilla-central/rev/461a7c923594#l1.334
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.