714453 - Make hashtable recursion assertions less ignorable

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

People seem to routinely ignore the hashtable assertions (see the multiple orange bugs with no traction even though they have completely usable stacks) so lets make the boom bigger.  This also will get us coverage in mochitest.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

These have pretty useless messages too... Any chance for something more useful? Maybe note how they're hit in these orange bugs?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think some of the orange bugs are actually threadsafety bugs rather than recursion.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yes, they are, but the recursion checking helps catch them.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 585144 [details] [diff] [review]
Patch

review- for editing a generated file.  (Sorry, should have gotten to this sooner.)

You should edit js/src/plify_jsdhash.sed and regenerate pldhash.cpp using it.  Unfortunately, it was removed in https://hg.mozilla.org/mozilla-central/rev/56b2068a28ea , so you'll first need to resurrect it and then sync any changes made incorrectly to only one of the files in question.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And, for reference, comments in sed files begin with #, which comments the rest of the line.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Given bug 783820, do comments 4 and 5 still apply here?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I suppose so.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Er, I suppose not.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Now with more modern assertions.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 724682 [details] [diff] [review]
Patch

r=dbaron

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f6fa0ad1273

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f6fa0ad1273