Closed Bug 714453 Opened 11 years ago Closed 10 years ago

Make hashtable recursion assertions less ignorable

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: khuey, Assigned: khuey)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
People seem to routinely ignore the hashtable assertions (see the multiple orange bugs with no traction even though they have completely usable stacks) so lets make the boom bigger.  This also will get us coverage in mochitest.
Attachment #585144 - Flags: review?(dbaron)
These have pretty useless messages too... Any chance for something more useful? Maybe note how they're hit in these orange bugs?
I think some of the orange bugs are actually threadsafety bugs rather than recursion.
Yes, they are, but the recursion checking helps catch them.
Comment on attachment 585144 [details] [diff] [review]
Patch

review- for editing a generated file.  (Sorry, should have gotten to this sooner.)

You should edit js/src/plify_jsdhash.sed and regenerate pldhash.cpp using it.  Unfortunately, it was removed in https://hg.mozilla.org/mozilla-central/rev/56b2068a28ea , so you'll first need to resurrect it and then sync any changes made incorrectly to only one of the files in question.
Attachment #585144 - Flags: review?(dbaron) → review-
And, for reference, comments in sed files begin with #, which comments the rest of the line.
Given bug 783820, do comments 4 and 5 still apply here?
Flags: needinfo?(dbaron)
I suppose so.
Flags: needinfo?(dbaron)
Er, I suppose not.
Attached patch PatchSplinter Review
Now with more modern assertions.
Attachment #585144 - Attachment is obsolete: true
Attachment #724682 - Flags: review?(dbaron)
Comment on attachment 724682 [details] [diff] [review]
Patch

r=dbaron
Attachment #724682 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/8f6fa0ad1273
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Blocks: 810718
You need to log in before you can comment on or make changes to this bug.