714467 - do_check_n/eq should perform strict equality check

Status: RESOLVED WONTFIX

(Testing :: XPCShell Harness, defect)

Description

[Asaf Romano (gone)]

do_check_eq seems to perform regular equality check. I have a use case for strict equality check (for now I'm just using do_check_true), and I think that switching all tests to work this way is better in general.

Comment 1

[Jeff Walden [:Waldo]]

Actually, if we're going to change this (and I'd love to see this changed), we should change to "sameness", not strict equality.  Sameness would treat NaN as identical to NaN, -0 as identical to -0 but not to +0, and +0 as identical to +0 but not -0.  The SameValue definition in js/src/tests/shell.js implements this:

http://hg.mozilla.org/mozilla-central/annotate/a447e66c3174/js/src/tests/shell.js#l266

Comment 2

[Asaf Romano (gone)]

Works for me.

I'll try to patch it on try sometime this week and see how much it burns.

Comment 3

[Asaf Romano (gone)]

do_check_n/eq are now deprecated in favor of (not)equal, and (not)deepEqual, which are what I asked for here (albeit they do much more than a simple === check). It's somewhat unfortunate that the deep checks are opt-in, but that's not going to change.

Comment 4

[Asaf Romano (gone)]

Oh, and there are also (not)strictEqual, which do simple ===/!== checks.