714495 - Port Bug 713167 - |Microsoft.VC80.CRT SideBySide errors, browsercomps.dll| to comm

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Justin Wood (:Callek)]

+++ This bug was initially created as a clone of Bug #713167 +++

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111220165912

Steps to reproduce:

Removed all .NET Framework and VC++ 2005 SP1 redistributable from Windows XP SP3.


Actual results:

Loading browsercomps.dll fails due to SideBySide error. This causes the problems such as the following:
* RSS feed function did not work correctly. For exanple: http://samlab.ws/rss/
* Decreased the number of items of "about:about".


Expected results:

Should load browsercomps.dll correctly.

Comment 1

[Justin Wood (:Callek)]

Attachment: v1

Requesting approval. This does just like the dep Firefox bug to fix a real issue on XP.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 585179 [details] [diff] [review]
v1

Thunderbird doesn't actually need this, as the mailcomps module is built into libxul.

I'm not quite sure what to do, but I'm leaning towards making it a comment near the top of the file that if we switch away from LIBXUL_LIBRARY at any stage, we need to clear the EMBED_MANIFEST_AT flag.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 585179 [details] [diff] [review]
v1

Cancelling requests pending new patch.

Comment 4

[Justin Wood (:Callek)]

Attachment: v2

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 586638 [details] [diff] [review]
v2

That's better, thanks.

Comment 6

[Justin Wood (:Callek)]

http://hg.mozilla.org/comm-central/rev/e87fb7e20146
http://hg.mozilla.org/releases/comm-aurora/rev/b70f9ff58d40
http://hg.mozilla.org/releases/comm-beta/rev/640523dc5946