Port Bug 713167 - |Microsoft.VC80.CRT SideBySide errors, browsercomps.dll| to comm

RESOLVED FIXED in Thunderbird 12.0

Status

MailNews Core
Build Config
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

({regression})

Thunderbird 12.0
x86
All
regression

Thunderbird Tracking Flags

(thunderbird10 fixed, thunderbird11 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
1019 bytes, patch
standard8
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #713167 +++

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111220165912

Steps to reproduce:

Removed all .NET Framework and VC++ 2005 SP1 redistributable from Windows XP SP3.


Actual results:

Loading browsercomps.dll fails due to SideBySide error. This causes the problems such as the following:
* RSS feed function did not work correctly. For exanple: http://samlab.ws/rss/
* Decreased the number of items of "about:about".


Expected results:

Should load browsercomps.dll correctly.
(Assignee)

Updated

6 years ago
Assignee: nobody → bugspam.Callek
Summary: Microsoft.VC80.CRT SideBySide errors, browsercomps.dll → Port Bug 713167 - |Microsoft.VC80.CRT SideBySide errors, browsercomps.dll| to comm
(Assignee)

Updated

6 years ago
status-firefox10: fixed → ---
status-firefox11: fixed → ---
status-firefox12: fixed → ---
status-firefox9: affected → ---
tracking-firefox10: + → ---
tracking-firefox11: + → ---
(Assignee)

Comment 1

6 years ago
Created attachment 585179 [details] [diff] [review]
v1

Requesting approval. This does just like the dep Firefox bug to fix a real issue on XP.
Attachment #585179 - Flags: review?(mbanner)
Attachment #585179 - Flags: approval-comm-beta?
Attachment #585179 - Flags: approval-comm-aurora?
Attachment #585179 - Attachment is patch: true
Comment on attachment 585179 [details] [diff] [review]
v1

Thunderbird doesn't actually need this, as the mailcomps module is built into libxul.

I'm not quite sure what to do, but I'm leaning towards making it a comment near the top of the file that if we switch away from LIBXUL_LIBRARY at any stage, we need to clear the EMBED_MANIFEST_AT flag.
Attachment #585179 - Flags: review?(mbanner) → review-
Comment on attachment 585179 [details] [diff] [review]
v1

Cancelling requests pending new patch.
Attachment #585179 - Flags: approval-comm-beta?
Attachment #585179 - Flags: approval-comm-aurora?
(Assignee)

Comment 4

6 years ago
Created attachment 586638 [details] [diff] [review]
v2
Attachment #585179 - Attachment is obsolete: true
Attachment #586638 - Flags: review?(mbanner)
Comment on attachment 586638 [details] [diff] [review]
v2

That's better, thanks.
Attachment #586638 - Flags: review?(mbanner)
Attachment #586638 - Flags: review+
Attachment #586638 - Flags: approval-comm-beta+
Attachment #586638 - Flags: approval-comm-aurora+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/comm-central/rev/e87fb7e20146
http://hg.mozilla.org/releases/comm-aurora/rev/b70f9ff58d40
http://hg.mozilla.org/releases/comm-beta/rev/640523dc5946
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-thunderbird10: --- → fixed
status-thunderbird11: --- → fixed
OS: Windows XP → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.