The default bug view has changed. See this FAQ.

[quirks] list bullet/number disappears when item that wraps has all contents in 2 nested inlines and inner inline has vertical-align: top/bottom

RESOLVED FIXED in mozilla12

Status

()

Core
Layout: Block and Inline
P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla12
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 585204 [details]
testcase

This is simplified from a report on css-d on December 23; original was http://dev.l-c-n.com/_temp/ck-20111223.html

In quirks mode or almost-standards mode, the list bullet or number disappears when:
 (a) a list item wraps to two lines, and
 (b) the entire contents of the list item are nested within two (or more) inlines, and an inline other than the outer one has vertical-align: top or bottom

The underlying reason for this is a bug in nsLineLayout::IsZeroHeight() (in layout/generic/nsLineLayout.cpp).  What it does to check for the line being zero height is not sufficient in quirks mode; it needs to look inside the children of the line since there might be top/bottom aligned frames that don't influence the height of their parent.

This breaks nsBlockFrame::PlaceLine (which uses two different tests for emptiness).


Then again, maybe we should fix this by limiting the inline layout quirks when there are top/bottom children, since that would also fix the text-decoration issue with the original testcase.
(Assignee)

Comment 1

5 years ago
Created attachment 585205 [details]
original (less simplified) testcase

... saved from url in comment 0.
(Assignee)

Comment 2

5 years ago
Created attachment 585219 [details] [diff] [review]
patch
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #585219 - Flags: review?(roc)
Attachment #585219 - Flags: review?(roc) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9152791a6f90
Priority: -- → P4
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/9152791a6f90
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.