Open
Bug 714520
Opened 14 years ago
Updated 11 years ago
editfields.cgi should make use of ->set_all
Categories
(Bugzilla :: Administration, task)
Tracking
()
NEW
People
(Reporter: bugzilla-mozilla, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
|
1.71 KB,
patch
|
LpSolit
:
review-
|
Details | Diff | Splinter Review |
No description provided.
Attachment #585206 -
Flags: review?(LpSolit)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 585206 [details] [diff] [review]
Patch v1
>+ $field->set_all({
>+ in_new_bugmail => $cgi->param('new_bugmail'),
>+ visibility_field => $cgi->param('visibility_field_id'),
>+ visibility_values => [ $cgi->param('visibility_values') ],
>+ value_field => $cgi->param('value_field_id'),
These keys do not exist as DB columns in the fielddefs table. You will have to check that things work correctly with VALIDATOR_DEPENDENCIES. Also, you must add "scalar" in front of each call to $cgi->param(), else you can get an incorrectly formatted hash.
Attachment #585206 -
Flags: review?(LpSolit) → review-
Updating the patch in its anniversary!
Attachment #585206 -
Attachment is obsolete: true
Attachment #696807 -
Flags: review?(LpSolit)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 696807 [details] [diff] [review]
patch v2
Next time, please test your patch! I just had to apply your patch to see Bugzilla crash. Also, don't ignore half of my review comments when updating a patch. I already said that some fields do not exist as is for validators.
Attachment #696807 -
Flags: review?(LpSolit) → review-
|
|
||
Updated•12 years ago
|
Assignee: bugzilla-mozilla → administration
Status: ASSIGNED → NEW
|
|
||
Updated•11 years ago
|
Target Milestone: Bugzilla 5.0 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•