714536 - Port |Bug 698630 - Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers| to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect, P4)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers [Checked in: Comment 5]

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

Sorry, as I've stated before, I'm not really interested in reviewing this sort of porting patch as it doesn't actually gain us anything and I'd prefer to spend the time elsewhere on improving the build system so we don't have to do this kind of port.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

(In reply to Mark Banner (:standard8) from comment #2)
> it doesn't actually gain us anything

My point here is packaging cleanup (only).

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

Review of attachment 587948 [details] [diff] [review]:
-----------------------------------------------------------------

Taking this strictly for package-manifest fixups.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/7bddc0e90669