The default bug view has changed. See this FAQ.

Port |Bug 698630 - Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers| to comm-central

RESOLVED FIXED in Thunderbird 12.0

Status

MailNews Core
Build Config
P4
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
Thunderbird 12.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #587948 - Flags: review?(mbanner)
Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

Sorry, as I've stated before, I'm not really interested in reviewing this sort of porting patch as it doesn't actually gain us anything and I'd prefer to spend the time elsewhere on improving the build system so we don't have to do this kind of port.
Attachment #587948 - Flags: review?(mbanner)
(Assignee)

Comment 3

5 years ago
Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

(In reply to Mark Banner (:standard8) from comment #2)
> it doesn't actually gain us anything

My point here is packaging cleanup (only).
Attachment #587948 - Flags: review?(kairo)
Attachment #587948 - Flags: review?(bugspam.Callek)
(Assignee)

Updated

5 years ago
Priority: -- → P4
Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

Review of attachment 587948 [details] [diff] [review]:
-----------------------------------------------------------------

Taking this strictly for package-manifest fixups.
Attachment #587948 - Flags: review?(kairo)
Attachment #587948 - Flags: review?(bugspam.Callek)
Attachment #587948 - Flags: review+
(Assignee)

Comment 5

5 years ago
Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/7bddc0e90669
Attachment #587948 - Attachment description: (Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers → (Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers [Checked in: Comment 5]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.