Last Comment Bug 714536 - Port |Bug 698630 - Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers| to comm-central
: Port |Bug 698630 - Remove --disable-smil build option and "#ifdef MOZ_SMIL" w...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: P4 minor (vote)
: Thunderbird 12.0
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on: 698630
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-01 10:28 PST by Serge Gautherie (:sgautherie)
Modified: 2012-01-17 19:05 PST (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers [Checked in: Comment 5] (3.98 KB, patch)
2012-01-11 21:31 PST, Serge Gautherie (:sgautherie)
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2012-01-01 10:28:33 PST

    
Comment 1 Serge Gautherie (:sgautherie) 2012-01-11 21:31:58 PST
Created attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]
Comment 2 Mark Banner (:standard8) (afk until 26th July) 2012-01-12 01:17:27 PST
Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

Sorry, as I've stated before, I'm not really interested in reviewing this sort of porting patch as it doesn't actually gain us anything and I'd prefer to spend the time elsewhere on improving the build system so we don't have to do this kind of port.
Comment 3 Serge Gautherie (:sgautherie) 2012-01-12 08:00:55 PST
Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

(In reply to Mark Banner (:standard8) from comment #2)
> it doesn't actually gain us anything

My point here is packaging cleanup (only).
Comment 4 Justin Wood (:Callek) 2012-01-17 05:11:12 PST
Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

Review of attachment 587948 [details] [diff] [review]:
-----------------------------------------------------------------

Taking this strictly for package-manifest fixups.
Comment 5 Serge Gautherie (:sgautherie) 2012-01-17 19:04:10 PST
Comment on attachment 587948 [details] [diff] [review]
(Av1) Remove --disable-smil build option and "#ifdef MOZ_SMIL" wrappers
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/7bddc0e90669

Note You need to log in before you can comment on or make changes to this bug.