714563 - Fix unused variable compiler warnings for Handle<T> class

Status: RESOLVED DUPLICATE of bug 713311

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

I'm still getting warnings with gcc 4.6.1.

Comment 1

[Tom S [:evilpie]]

Better compiler analysis is just going to uncover that, could we use something like 
this http://stackoverflow.com/questions/965093/selectively-disable-gcc-warnings-for-only-part-of-a-translation-unit ?

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 585234 [details] [diff] [review]
patch

Is there anything wrong with the old-fashioned |(void)a;| ?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Does that work? I used the scheme here because that's what Chrome does in their handle class.

Comment 4

[Nicholas Nethercote [inactive]]

I've used it lots of times in the past and I don't see any reason why it wouldn't work here.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I guess Luke already fixed this here:
http://hg.mozilla.org/mozilla-central/rev/f0d76403ae9c

Comment 6

[Luke Wagner [:luke]]

Yeah, that warning was annoying.  I used (void)a.