Closed Bug 714574 Opened 8 years ago Closed 8 years ago

Unable to upload trunk zh-TW on mac, due to SEARCH_PLUGINS failure.

Categories

(SeaMonkey :: Build Config, defect, blocker)

All
Windows 7
defect
Not set
blocker

Tracking

(seamonkey2.9 fixed)

RESOLVED FIXED
seamonkey2.9
Tracking Status
seamonkey2.9 --- fixed

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(2 files)

Attached patch v1Splinter Review
I noticed over the past few days that our newly added zh-TW on mac was not uploading correctly (timing out, without any make output)

I today logged into the mac machine that tried it and did |make upload| call just like buildbot attempted to do, and when that also failed, tried it with -d to get debug output... this proved unhelpful... (I'll attach log after)

After that I remembered that pymake has slightly better debugging output, so I ran it with pymake, which pointed at SEARCH_PLUGINS being attempted to run a |cat | with no file, and of course that could cause a hang.

A bit of MXR-searching later, and I see that my hacked up solution, which existed before the now widely used MERGE_FILE[S] seems to be broken...

I edited the SEARCH_PLUGINS command there on the slave to use MERGE_FILE instead and re-ran pymake, and it all succeeded.

Mark/Robert, whichever of you gets this first, I'll be happy.

------------------------------------------
(Broken output log will be attached separately)
------------------------------------------
Attachment #585245 - Flags: review?(mbanner)
Attachment #585245 - Flags: review?(kairo)
Attached file Failed Testing Logs
Version: SeaMonkey 2.7 Branch → Trunk
Attachment #585245 - Flags: review?(mbanner)
Attachment #585245 - Flags: review?(kairo)
Attachment #585245 - Flags: review+
Target Milestone: --- → seamonkey2.9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.