714583 - Labels of inline options shouldn't get cropped

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Wladimir Palant]

Steps to reproduce:

1. Install Customization for Adblock Plus extension from https://addons.mozilla.org/addon/abpcustomization/.
2. Press Ctrl-Shift-A to open the Add-ons Manager.
3. Click the Options button for Customization extension.
4. Reduce the size of the browser window.

Expected result:

As the window size gets smaller, the option labels wrap around but stay readable.

Actual result:

Option labels get cropped. There isn't even a tooltip meaning that reading them becomes impossible.

This is apparently an issue for some users who don't run Firefox maximized. Making the labels shorter is not an options because it is unclear which window width should be expected (and communicating width restrictions to translators is close to impossible anyway). While it might make sense to crop the labels if only very little space is available (on mobile), on desktop the label should definitely just wrap. This change to chrome://mozapps/content/extensions/setting.xml should do:

-      <xul:label class="settings-title" xbl:inherits="value=label" crop="end" flex="1"/>
+      <xul:label class="settings-title" xbl:inherits="xbl:text=label" flex="1"/>

Checked that the issue still exists in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120101 Firefox/12.0a1.

Comment 1

[Wladimir Palant]

This change is also required of course (in several places):

-        <xul:label class="preferences-title" xbl:inherits="value=title" crop="end" flex="1"/>
+        <xul:label class="preferences-title" xbl:inherits="xbl:text=title" flex="1"/>

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: patch

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 585260 [details] [diff] [review]
patch

Review of attachment 585260 [details] [diff] [review]:
-----------------------------------------------------------------

Remove the crop="end" attribute too. Also, better give the description label (preferences-description) the same treatment so it also wraps.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: patch v2

(In reply to Blair McBride (:Unfocused) from comment #3)
> Remove the crop="end" attribute too.

Oh duh, I'm really clever...

Comment 5

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57d4b43b95a4

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/57d4b43b95a4