714595 - Simplify FillIdentityList() and getCurrentIdentity().

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[Philip Chee]

>> function compareAccountSortOrder(account1, account2)
>> {
>>+  var ds = Components.classes["@mozilla.org/rdf/datasource;1?name=msgaccountmanager"]
>>+                     .getService(Components.interfaces.nsIRDFDataSource);
> How expensive is it to move this into the sort function? I guess most people do not have that many accounts but worth checking.

I'll fix this by porting more of jminta's thunderbird patch.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed Fix.

> -  var ds = Components.classes["@mozilla.org/rdf/datasource;1?name=msgaccountmanager"]
> -                     .getService(Components.interfaces.nsIRDFDataSource);
This should help with the de-RDF effort.

> +  accounts = accounts.filter(function isNonSuckyAccount(a) {return !!a.incomingServer;});
isNonSuckyAccount() is what Thunderbird uses!

> -    // fill in Identity combobox
Drive by fix. Magnus did this for Thunderbird recently.

Comment 2

[Karsten Düsterloh]

Comment on attachment 585266 [details] [diff] [review]
Patch v1.0 Proposed Fix.

>+  // Ugly hack to work around bug 41133. :-(
>+  accounts = accounts.filter(function isNonSuckyAccount(a) {return !!a.incomingServer;});

Inner functions should adhere to the Mozilla/SM MailNews style guide as well, e.g. IsNonSuckyAccount(aAccount) here.

>+  function sortAccounts(a, b)

Same here.

moa=me with that.

Comment 3

[Philip Chee]

Attachment: Patch v1.1 as checked in r=IanN moz=Mnyromyr.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/edae64607f3d

> Inner functions should adhere to the Mozilla/SM MailNews style guide as well,
> e.g. IsNonSuckyAccount(aAccount) here.
Fixed.