714657 - Blow away stored prefs during setup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Richard Newman [:rnewman]]

Uninstallation/reinstallation of Fennec will often cause your Sync account to disappear. Alas, that doesn't cause your prefs to be wiped, and so your last sync timestamps persist.

We should wipe the whole pref tree prior to writing at the end of setup.

Comment 1

[Richard Newman [:rnewman]]

In fact, we can probably do this in our equivalent of resetClient, which we should do on a first sync. Need to implement first sync logic, of course :)

Comment 2

[Richard Newman [:rnewman]]

This has an impact on testing, so setting a priority.

Comment 4

[Nick Alexander :nalexander [he/him]]

To verify this happens before fix is applied:

1. pair device with desktop
2. force sync
3. delete Android account
4. (quickly) pair device a second time with same Sync account
5. verify first sync after pairing does not happen and a log entry like the following is present:

I SyncAdapter(22616)          Not syncing: must wait another 232943ms.

To verify this has been fixed:

Repeat steps 1. through 4.  On step 5., you should see a full sync happen, and you should have log entries like the following present:

W GlobalSession(24855)        Remote syncID different from local syncID: resetting client and assuming remote syncID.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6bbc085e39b5

Comment 6

[Xiao Meng Wei :xwei]

With the latest inbound build (20120612), I am still seeing :
Not syncing: must wait another xxx ms.
right after pairing device a second time with the same sync account.

Comment 7

[Nick Alexander :nalexander [he/him]]

(In reply to Xiao Meng Wei :xwei from comment #6)
> With the latest inbound build (20120612), I am still seeing :
> Not syncing: must wait another xxx ms.
> right after pairing device a second time with the same sync account.

My guess is we need to wait to get the right build.  Can we leave this until tomorrow's nightly?

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6bbc085e39b5

Comment 9

[Andreea Pod]

Following the steps from comment 4, all works as expected. 

Verified fixed on 
- build: Firefox 16.0a1 (2012-06-14)
- device: Samsung Galaxy SII 
- SO: Android 2.3.4