Closed
Bug 71470
Opened 25 years ago
Closed 25 years ago
[XUL Syntax] Add support for command observers to use command="" instead of observes=""
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9
People
(Reporter: hyatt, Assigned: mikepinkerton)
References
Details
(Whiteboard: [XUL1.0])
Attachments
(8 files)
|
6.89 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.98 KB,
patch
|
Details | Diff | Splinter Review | |
|
6.99 KB,
patch
|
Details | Diff | Splinter Review | |
|
6.07 KB,
patch
|
Details | Diff | Splinter Review | |
|
6.73 KB,
patch
|
Details | Diff | Splinter Review | |
|
7.39 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.70 KB,
patch
|
Details | Diff | Splinter Review | |
|
80.76 KB,
patch
|
Details | Diff | Splinter Review |
... and make menus and keys smarter about not getting attrs set on them and not
updating until they're shown.
|
Reporter | |
Updated•25 years ago
|
Blocks: 70753
Status: NEW → ASSIGNED
Summary: [XUL Syntax] Convert command observers to use command="" instead of observes="" → [XUL Syntax] Add support for command observers to use command="" instead of observes=""
Whiteboard: [XUL1.0]
Target Milestone: --- → mozilla0.8.1
|
|
Reporter | |
Updated•25 years ago
|
Target Milestone: mozilla0.8.1 → mozilla0.9
|
|
Reporter | |
Comment 1•25 years ago
|
||
Adding pinkerton to cc list. pinkerton has volunteered to be the Mac bitch on
this one.
|
|
Reporter | |
Comment 2•25 years ago
|
||
|
|
Reporter | |
Comment 3•25 years ago
|
||
|
|
Reporter | |
Comment 4•25 years ago
|
||
pink, you need to patch the Mac menu oncreate code.
|
|
Reporter | |
Comment 5•25 years ago
|
||
My patch wasn't quite right. Better patches coming up.
|
|
Reporter | |
Comment 6•25 years ago
|
||
|
|
Reporter | |
Comment 7•25 years ago
|
||
|
|
Reporter | |
Comment 8•25 years ago
|
||
|
|
Reporter | |
Comment 9•25 years ago
|
||
|
|
Reporter | |
Comment 10•25 years ago
|
||
Ready for r and sr on the latest content and layout patches.
|
|
Reporter | |
Comment 11•25 years ago
|
||
|
||
Comment 12•25 years ago
|
||
r=jag on attach_id=28184
r=jag on attach_id=28191
|
||
Comment 13•25 years ago
|
||
Can we share some of that child-walking code in MenuFrame and PopupSetFrame in a
helper function somewhere?
|
|
Reporter | |
Comment 14•25 years ago
|
||
I'm going to eliminate <popupset> for 1.0, so it won't matter. I have a bug on
that already.
|
|
||
Comment 15•25 years ago
|
||
Well, fine then.
sr=shaver
|
|
Assignee | |
Comment 16•25 years ago
|
||
|
|
Assignee | |
Comment 17•25 years ago
|
||
i just rewrote mac menus to use nsIContent while I was at it. The patch is big,
but a lot of the changes are spacing changes (god was the indenting in these
files bad) and a lot of repeated nsIDOMNode->nsIContent patterns.
I tested browser/mail/composer and menus, submenus, disabled items, check menus,
radio menus, etc all work fine.
Need r/sr for these. saari? hyatt? sfraser?
|
|
Reporter | |
Comment 18•25 years ago
|
||
sr=hyatt on pink's changes
|
|
Reporter | |
Comment 19•25 years ago
|
||
My changes are in. Reassigning the bug to pinkerton.
Assignee: hyatt → pinkerton
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 20•25 years ago
|
||
fixed. new menu changes in on mac and macosx.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•25 years ago
|
|
|
||
Comment 21•25 years ago
|
||
Platform on this bug shows PC, but I assume the fix affects only the Mac? I'll
get QA to take a look at menus in the builds from today.
|
|
Assignee | |
Comment 22•25 years ago
|
||
this affects all platforms.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•