NullPointerException at GeckoInputConnection.notifyIME

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

unspecified
Firefox 12
x86
Linux
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

Attachments

(1 attachment)

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoInputConnection.java#594

The | if | check is wrong. This should be:

if (imm == null) { ... } else { imm.restartInput(v); }
Created attachment 585350 [details] [diff] [review]
patch

simple patch
Assignee: alexp → mark.finkle
Attachment #585350 - Flags: review?(doug.turner)

Updated

5 years ago
Attachment #585350 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddf371bc13f0
https://hg.mozilla.org/mozilla-central/rev/ddf371bc13f0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 585350 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. The previous code was just wrong and would have caused a exception.
Attachment #585350 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
Comment on attachment 585350 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #585350 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: --- → 11+
https://hg.mozilla.org/releases/mozilla-aurora/rev/f9c0454b1642
status-firefox11: --- → fixed
status-firefox12: --- → fixed
You need to log in before you can comment on or make changes to this bug.