714708 - NullPointerException at GeckoInputConnection.notifyIME

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoInputConnection.java#594

The | if | check is wrong. This should be:

if (imm == null) { ... } else { imm.restartInput(v); }

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

simple patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ddf371bc13f0

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ddf371bc13f0

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 585350 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. The previous code was just wrong and would have caused a exception.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 585350 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f9c0454b1642