714711 - A few unused local variables in PanZoomController.onScaleEnd

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

This variables are unused and I can't tell if we wanted to use them and forgot, or if we can safely remove the code:

"o" : http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/ui/PanZoomController.java#980
"viewport" : http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/ui/PanZoomController.java#988
"pageRect" : http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/ui/PanZoomController.java#991

Comment 1

[Kartikaya Gupta (email:[e-mail])]

According to the blame, viewport and pageRect can be removed (accidentally left behind after other code was removed) but I'm not sure about "o" - wesj added that in his double-tap zoom support patch (bug 697701) but it was never used.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Removes the unused locals. "pageSize" was only used for "pageRect" so it could be removed too.

If Wes needed "o" he can mention in feedback.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 585411 [details] [diff] [review]
patch

Review of attachment 585411 [details] [diff] [review]:
-----------------------------------------------------------------

I ended up doing going through more revisions of double tap zoom than i wanted. I think that was just left over cruft that snuck through :(

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91e7e04c53b5

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/91e7e04c53b5

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 585411 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. No risk

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 585411 [details] [diff] [review]
patch

[Triage Comment]
Doesn't seem as if this is needed for Aurora since it's only removing unused variables.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 585411 [details] [diff] [review]
patch

needed due to dependencies

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/31ee4b6cedea