Closed Bug 714711 Opened 8 years ago Closed 8 years ago

A few unused local variables in PanZoomController.onScaleEnd

Categories

(Firefox for Android :: General, defect, P3)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
fennec 11+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(1 file)

According to the blame, viewport and pageRect can be removed (accidentally left behind after other code was removed) but I'm not sure about "o" - wesj added that in his double-tap zoom support patch (bug 697701) but it was never used.
Attached patch patchSplinter Review
Removes the unused locals. "pageSize" was only used for "pageRect" so it could be removed too.

If Wes needed "o" he can mention in feedback.
Assignee: bugmail.mozilla → mark.finkle
Attachment #585411 - Flags: review?(bugmail.mozilla)
Attachment #585411 - Flags: feedback?(wjohnston)
Attachment #585411 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 585411 [details] [diff] [review]
patch

Review of attachment 585411 [details] [diff] [review]:
-----------------------------------------------------------------

I ended up doing going through more revisions of double tap zoom than i wanted. I think that was just left over cruft that snuck through :(
Attachment #585411 - Flags: feedback?(wjohnston) → feedback+
https://hg.mozilla.org/mozilla-central/rev/91e7e04c53b5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 585411 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. No risk
Attachment #585411 - Flags: approval-mozilla-aurora?
Comment on attachment 585411 [details] [diff] [review]
patch

[Triage Comment]
Doesn't seem as if this is needed for Aurora since it's only removing unused variables.
Attachment #585411 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
tracking-fennec: --- → 11+
Comment on attachment 585411 [details] [diff] [review]
patch

needed due to dependencies
Attachment #585411 - Flags: approval-mozilla-aurora- → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.