714713 - Comparison of strings using ==

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

AFAIK, we can only use String1.equal(String2) to compare strings in Java, unless the strings are constants.

This patch fixes 2 places I found that use ==

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0284b1ff46c6

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

had to backout because of some NullPointerException (mLastUri and mLastTitle can be null)

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d00e560e0dc

I'll get a new patch soon

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch uses mUri.equals, since mUri is not null. I also dropped the mTitle check since mUri is unique enough.

This patch passed Try server

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c90dc56f83f0

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/c90dc56f83f0

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 585406 [details] [diff] [review]
patch 2

[Approval Request Comment]
Code cleanup. No risk

Uses the correct method to compare strings. The SnapshotSessionRunnable code could have been being called too often before this patch.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 585406 [details] [diff] [review]
patch 2

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5e4a83c69eef