Closed Bug 714713 Opened 9 years ago Closed 9 years ago
Comparison of strings using ==
AFAIK, we can only use String1.equal(String2) to compare strings in Java, unless the strings are constants. This patch fixes 2 places I found that use ==
Attachment #585352 - Flags: review?(doug.turner)
Attachment #585352 - Flags: review?(doug.turner) → review+
had to backout because of some NullPointerException (mLastUri and mLastTitle can be null) https://hg.mozilla.org/integration/mozilla-inbound/rev/1d00e560e0dc I'll get a new patch soon
This patch uses mUri.equals, since mUri is not null. I also dropped the mTitle check since mUri is unique enough. This patch passed Try server
Attachment #585406 - Flags: review?(doug.turner) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 585406 [details] [diff] [review] patch 2 [Approval Request Comment] Code cleanup. No risk Uses the correct method to compare strings. The SnapshotSessionRunnable code could have been being called too often before this patch.
Attachment #585406 - Flags: approval-mozilla-aurora?
Comment on attachment 585406 [details] [diff] [review] patch 2 [Triage Comment] Mobile only - approved for Aurora.
Attachment #585406 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.