Closed Bug 714713 Opened 12 years ago Closed 12 years ago

Comparison of strings using ==

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 fixed, firefox12 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file, 1 obsolete file)

patch 2
2.01 KB, patch
dougt
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
AFAIK, we can only use String1.equal(String2) to compare strings in Java, unless the strings are constants.

This patch fixes 2 places I found that use ==
Attachment #585352 - Flags: review?(doug.turner)
Attachment #585352 - Flags: review?(doug.turner) → review+
had to backout because of some NullPointerException (mLastUri and mLastTitle can be null)

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d00e560e0dc

I'll get a new patch soon
Attachment #585352 - Flags: review+ → review-
Attached patch patch 2 — — Splinter Review 
This patch uses mUri.equals, since mUri is not null. I also dropped the mTitle check since mUri is unique enough.

This patch passed Try server
Assignee: nobody → mark.finkle
Attachment #585352 - Attachment is obsolete: true
Attachment #585406 - Flags: review?(doug.turner)
Attachment #585406 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/c90dc56f83f0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 585406 [details] [diff] [review]
patch 2

[Approval Request Comment]
Code cleanup. No risk

Uses the correct method to compare strings. The SnapshotSessionRunnable code could have been being called too often before this patch.
Attachment #585406 - Flags: approval-mozilla-aurora?
Comment on attachment 585406 [details] [diff] [review]
patch 2

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #585406 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.