Variable is used before a null check in GeckoApp.launch

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

unspecified
Firefox 12
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Created attachment 585353 [details] [diff] [review]
patch

"intent" is used here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoApp.java#395

before it is null checked here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoApp.java#401
Attachment #585353 - Flags: review?(doug.turner)

Updated

6 years ago
Attachment #585353 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/172f007cc17c
https://hg.mozilla.org/mozilla-central/rev/172f007cc17c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 585353 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. No risk
Prevents a possible NullPointerException
Attachment #585353 - Flags: approval-mozilla-aurora?

Comment 4

6 years ago
Comment on attachment 585353 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #585353 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/3fb197649a87
status-firefox11: --- → fixed
status-firefox12: --- → fixed
Whiteboard: [qa-]
Assignee: nobody → mark.finkle
OS: Linux → Android
Hardware: x86 → All
You need to log in before you can comment on or make changes to this bug.