714726 - Follow up for bug 603941 - (fx40-p12n-as) [as] Firefox productization review for Assamese

Status: RESOLVED FIXED

(Mozilla Localizations :: as / Assamese, defect)

Description

[Nilamdyuti]

Attachment: patch for removing bloglines from 1.9.2 for Assamese

From https://bugzilla.mozilla.org/show_bug.cgi?id=603941#c4 ; attaching a patch for removing bloglines from 1.9.2 for Assamese and requesting a review on the patch.

Comment 1

[Nilamdyuti]

Comment on attachment 585366 [details] [diff] [review]
patch for removing bloglines from 1.9.2 for Assamese

Please review the patch and let me know the feedback.

Comment 2

[Nilamdyuti]

Comment on attachment 585366 [details] [diff] [review]
patch for removing bloglines from 1.9.2 for Assamese

Please review the patch and let me know the feedback.

Comment 3

[Nilamdyuti]

ping?

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 585366 [details] [diff] [review]
patch for removing bloglines from 1.9.2 for Assamese

Review of attachment 585366 [details] [diff] [review]:
-----------------------------------------------------------------

r- on the bing line, the rest looks good.

::: old/region.properties
@@ +3,5 @@
>  
>  # Search engine order (order displayed in the search bar dropdown)s
>  browser.search.order.1=Google
>  browser.search.order.2=Yahoo
> +browser.search.order.3=Bing

This one shouldn't be here.

If we'd add bing to the searchplugins, it'd be part of that bug.

Right now, if some user installs a bing searchplugin, this is likely to kick in an explicit ordering, and we mustn't do that.

Comment 5

[Nilamdyuti]

Attachment: patch for removing bloglines from 1.9.2 for Assamese

This patch is for 1.9.2 for Assamese as asked for in https://bugzilla.mozilla.org/show_bug.cgi?id=603941#c1

Comment 6

[Nilamdyuti]

Attachment: patch for removing bing and changing My Yahoo! from mozilla-beta for Assamese

This patch is for Firefox-beta as asked for in https://bugzilla.mozilla.org/show_bug.cgi?id=603941#c4

Comment 7

[Nilamdyuti]

Attachment: patch for removing bing and changing My Yahoo! from mozilla-aurora for Assamese

This patch is for Firefox-aurora

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 585981 [details] [diff] [review]
patch for removing bing and changing My Yahoo! from mozilla-aurora for Assamese

Review of attachment 585981 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Please land this with a check-in comment referencing this bug and my review, something like "bug 714726, remove bing ordering and untranslate My Yahoo!, r=[e-mail]" would be good.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 585980 [details] [diff] [review]
patch for removing bing and changing My Yahoo! from mozilla-beta for Assamese

Review of attachment 585980 [details] [diff] [review]:
-----------------------------------------------------------------

... same here.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 585979 [details] [diff] [review]
patch for removing bloglines from 1.9.2 for Assamese

We shouldn't touch 1.9.2 anymore, we're hoping to get folks off of 3.6 soon. Sorry, probably could have said that earlier, too.

Comment 11

[Nilamdyuti]

No worries, I landed the changes with a check-in comment both for aurora and beta.

Ref: http://hg.mozilla.org/releases/l10n/mozilla-aurora/as

Ref: http://hg.mozilla.org/releases/l10n/mozilla-beta/as

Comment 12

[Axel Hecht [:Pike]]

Thanks, this is fixed now on both aurora and beta.

Comment 13

[Nilamdyuti]

Thanks! :)