714743 - [Firefox] removed-files.in: is full-screen-override.css removal actually (always) needed?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 702146 added this unconditional removal.
Is it needed at all?
Should it rather be in '#ifdef MOZ_OMNIJAR'?

Comment 1

[Boris Zbarsky [:bzbarsky]]

I have no idea.  Someone familiar with the packaging stuff would be better to ask.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)

> Bug 702146 added this unconditional removal.

https://hg.mozilla.org/mozilla-central/rev/bb3bfc552568

> Is it needed at all?

full-screen-override.css is a new file,
and is packaged inside (layout/style/jar.mn >) toolkit.jar.
Hence, there is no reason to ever remove it, is it?

> Should it rather be in '#ifdef MOZ_OMNIJAR'?

That would probably rather be "if not flat", but I don't think we care about that.

Comment 3

[Phoenix]

Is this still actual?

Comment 4

[Phoenix]

Bump?

Comment 5

[Serge Gautherie (:sgautherie)]

(Phoenix, sorry for the (2-year) delay!)

It seems this bug was still actual,
but bug 649607 eventually removed the "full-screen-override.css" line.

R.Fixed