714751 - XHR needs to cancel channels with a failure code

Status: RESOLVED DUPLICATE of bug 1191981

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 585376 [details] [diff] [review]
Patch

I'm not familiar with this strange looking blob handling in XHR.
Sicking and Masatoshi should know better.

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 585376 [details] [diff] [review]
Patch

NS_OK is required here, otherwise the cache entry for the blob response will be doomed.
At least you also need to modify codes about caching.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Hmm, the nsIRequest docs say that the code needs to be a failure code.  Guess we'll need to fix the cache here.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 585376 [details] [diff] [review]
Patch

Yeah, we need other or more changes here.

As an aside, does this pass tests? If so that's probably an indication that our tests aren't good enough.