714818 - Pulse message for l10n-dep builds misses 'appVersion' and 'appName' properties in build information

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With the implementation of the Mozmill CI system we want to run Mozmill l10n tests for each check-in done by localizers. To make this happen we listen for the l10n-dep notifications from the BuildConsumer on the Pulse network, e.g. 'build.mozilla-aurora-linux64-l10n-dep.657.finished'.

Sadly the related Pulse messages do not contain any of the necessary build information. To successfully execute the l10n tests we need the following properties set:

* product
* branch
* buildid (to be added for macosx64 across branches)
* locale
* platform
* appVersion (to be added for all platforms across branches)

Properties which have to be added, I have marked in brackets. So far nothing more is needed as I can see.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks like the buildid part is fixed. I now can see this property across platforms. So I will work on a patch for appVersion.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Chris, I assume the appversion has to be added here:
http://hg.mozilla.org/build/buildbotcustom/file/f40fec804a5e/misc.py#l2395

Can you please tell me where I get the appVersion from? Does it come with the pf dict?

Comment 3

[Chris AtLee [:catlee]]

I believe it gets set here:
http://hg.mozilla.org/build/buildbotcustom/file/f40fec804a5e/process/factory.py#l3863

It looks like it's only enabled for the nightly repack jobs at the moment. Those two SetProperty steps could probably be moved outside the 'if self.l10nNightlyUpdate:' block.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Sorry, for forgetting about this bug. Just found it while digging through old assigned bugs. Here the patch to move those to setProperty calls out of the if condition. It's untested so you might want to have a check if that works as expected.

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 779638 [details] [diff] [review]
Patch v1

Review of attachment 779638 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me! Thanks for the patch.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Chris, it would be great if you could take care of its landing. Thanks.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I assume the bug can be closed now. Thanks for the landing.

http://hg.mozilla.org/build/buildbotcustom/rev/8511028bb750

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

It's not merge to production or deployed yet. The buildduty person will do that in the next few days for that and will comment here, then the bug can be closed.

Comment 9

[Rail Aliiev [:rail]]

In production

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So can we close this bug now as fixed?

Comment 11

[Rail Aliiev [:rail]]

If it fixed the issue - sure, go ahead and resolve the bug.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Explicitely checked one of the last pulse messages:

["appVersion", "25.0a2", "SetProperty Step"]
["appName", "Firefox", "SetProperty Step"]

So it's fixed.