714920 - Context menu for an empty input field should not include "Copy All" or "Select All"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Aaron Train [:aaronmt]]

Long tapping on an empty input field presents the context menu with the options: "Copy All", "Select All", and "Select Input Method". Of those, only the third option would be of interest in this situation. Rather than invoking the context menu on an empty field, a long tap should be just interpreted as an attempt to focus the field.

STR: http://mail.yahoo.com, long tap into the empty 'Yahoo! ID' or 'Password' field.

Comment 1

[Matt Brubeck (:mbrubeck)]

I'm not sure about this.  "Paste" and "Select Input Method" are both valid for empty input fields.  If you want to focus the input field, why not just single-tap on it?

We should definitely eliminate "Copy All" and "Select All" when the field is empty.

Comment 2

[Matt Brubeck (:mbrubeck)]

Removing [parity-stock] because the stock browser does display a context menu for empty input fields, at least in my HTC T-Mobile G2 (stock Android 2.3).

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's just fixup the context menu entries for an empty textbox. Adjust bug summary as needed.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This hides the "Copy All" and "Select All" when there is nothing to copy or select.

This also steals a line from XUL fennec to hide "Copy" and "Copy All" for password fields.

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f383c28a6dfa

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 587800 [details] [diff] [review]
patch

[Approval Request Comment]
This is a low-risk Android-only patch that fixes several cases where the wrong context menu items appear for form fields.

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/f383c28a6dfa

Comment 8

[Carla Nadastean]

Verified on 
Nightly 12.0a1 (2012-01-16) "Select Input Method" and "Paste" options are displayed.

Still reproducible on Aurora 11.0a2 (2012-01-15).

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 587800 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1464a59212ac

Comment 11

[Carla Nadastean]

Verified on Aurora 11.0a2 (2012-01-17)
Only "Select Input Method" and "Paste" options are displayed for empty fields.