714978 - change mac osx compiler in official branded beta+release builds from using "-j1" to "-j4".

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

1) From RelEng meeting today: we have already been using "-j4" for m-c/aurora/beta nightlies; this is a change for "beta release" and "release" builds only.

2) From RapidRelease/cadence meeting: release drivers verbally ok'd to land this in FF10.0b3.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: add -j4 to mozconfigs for {macosx,macosx64}/mozilla-{release,beta}

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 585582 [details] [diff] [review]
add -j4 to mozconfigs for {macosx,macosx64}/mozilla-{release,beta}

These days you want browser/config/mozconfigs/macosx-universal/release in the mozilla-beta repo. We would also need to land the change in m-c and m-a, so that it propagates through for future betas. Don't think you need to do m-r, because the in-tree mozconfigs aren't there until the next merge.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Oh, and we can probably make the same change for linux32/linux64 too, even though they're not the long pole for releases. Windows will have to stay at -j1 until we're using pymake.

joduinn that the meeting only signed off on doing mac though.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: in-tree mozconfigs for mozilla-beta linux{32,64} and macosx-universal

Comment 5

[Rail Aliiev [:rail]]

Should we also sync the configs to mozilla-aurora and mozilla-central repos to prevent conflicts in the future?

Comment 6

[Rail Aliiev [:rail]]

Will this be gone from mozilla-beta after mozilla-aurora -> mozilla-beta merge? If yes, we should land this patch on mozilla-central and mozilla-aurora as well.

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 585626 [details] [diff] [review]
in-tree mozconfigs for mozilla-beta linux{32,64} and macosx-universal

This doesn't affect mozilla-aurora and mozilla-central because we don't build releases off them. It simplifies m-c -> m-a -> m-b migration though.

Risk to taking this patch (and alternatives if risky): low

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 585626 [details] [diff] [review]
in-tree mozconfigs for mozilla-beta linux{32,64} and macosx-universal

[Triage Comment]
Approved for Aurora.

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 585626 [details] [diff] [review]
in-tree mozconfigs for mozilla-beta linux{32,64} and macosx-universal

Landed on mozilla-aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/098475237afe
And mozilla-central: http://hg.mozilla.org/mozilla-central/rev/294b0fcf805b

Comment 10

[Rail Aliiev [:rail]]

The changes somehow have been disappeared from mozilla-beta:

http://hg.mozilla.org/releases/mozilla-beta/file/7be7d0bdedcd/browser/config/mozconfigs/linux32/release

http://hg.mozilla.org/releases/mozilla-beta/file/7be7d0bdedcd/browser/config/mozconfigs/linux64/release

http://hg.mozilla.org/releases/mozilla-beta/file/7be7d0bdedcd/browser/config/mozconfigs/macosx-universal/release

Aurora has the changes:

http://hg.mozilla.org/releases/mozilla-aurora/file/default/browser/config/mozconfigs/linux32/release
http://hg.mozilla.org/releases/mozilla-aurora/file/default/browser/config/mozconfigs/linux64/release
http://hg.mozilla.org/releases/mozilla-aurora/file/default/browser/config/mozconfigs/macosx-universal/release

mozilla-central is ok as well:
http://hg.mozilla.org/mozilla-central/file/default/browser/config/mozconfigs/linux32/release
http://hg.mozilla.org/mozilla-central/file/default/browser/config/mozconfigs/linux64/release
http://hg.mozilla.org/mozilla-central/file/default/browser/config/mozconfigs/macosx-universal/release

Can we reland this on beta?

Comment 11

[[e-mail] (:bhearsum)]

Looks like Alex cut the merge off at http://hg.mozilla.org/releases/mozilla-aurora/rev/43065851180a, which was prior to our landing, so this didn't make it to beta. I just landed it manually there: http://hg.mozilla.org/releases/mozilla-beta/rev/ac0ccdaf0fd8