"ASSERTION: wrong node" and crash [@ nsIRange::UnregisterCommonAncestor]

RESOLVED FIXED in mozilla12

Status

()

Core
Selection
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: Mats Palmgren (vacation - back in August))

Tracking

(Blocks: 1 bug, {assertion, crash, testcase})

Trunk
mozilla12
assertion, crash, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(4 attachments)

(Reporter)

Description

6 years ago
Created attachment 585640 [details]
testcase (crashes Firefox when closed)

Closing the testcase triggers:

###!!! ASSERTION: wrong node: 'aNode->IsCommonAncestorForRangeInSelection()', file /builds/slave/m-cen-osx64-dbg/build/content/base/src/nsRange.cpp, line 429

Crash [@ nsIRange::UnregisterCommonAncestor]
(Reporter)

Comment 1

6 years ago
Created attachment 585641 [details]
stack trace
The text nodes we're normalizing are children of the document, so we're falsely
triggering aNotInsertedYet==true in nsRange::CharacterDataChanged:
http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsRange.cpp#556
because I should have used GetNodeParent(), not GetParent().  Bah!

Try results pending:
https://tbpl.mozilla.org/?tree=Try&rev=5b0e7f840554
Assignee: nobody → matspal
OS: Mac OS X → All
Hardware: x86_64 → All
Created attachment 585853 [details] [diff] [review]
fix
Attachment #585853 - Flags: review?(bugs)
Created attachment 585854 [details] [diff] [review]
crashtest

Updated

6 years ago
Attachment #585853 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/cddeb9fcc249
https://hg.mozilla.org/integration/mozilla-inbound/rev/db09603b4186
Flags: in-testsuite+
Keywords: crash
Whiteboard: [inbound]
Target Milestone: --- → mozilla12

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/cddeb9fcc249
https://hg.mozilla.org/mozilla-central/rev/db09603b4186
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.