Closed
Bug 715056
Opened 13 years ago
Closed 13 years ago
"ASSERTION: wrong node" and crash [@ nsIRange::UnregisterCommonAncestor]
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: jruderman, Assigned: MatsPalmgren_bugz)
Details
(Keywords: assertion, crash, testcase, Whiteboard: [inbound])
Attachments
(4 files)
339 bytes,
text/html
|
Details | |
10.81 KB,
text/plain
|
Details | |
2.94 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
1.17 KB,
patch
|
Details | Diff | Splinter Review |
Closing the testcase triggers:
###!!! ASSERTION: wrong node: 'aNode->IsCommonAncestorForRangeInSelection()', file /builds/slave/m-cen-osx64-dbg/build/content/base/src/nsRange.cpp, line 429
Crash [@ nsIRange::UnregisterCommonAncestor]
Reporter | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
The text nodes we're normalizing are children of the document, so we're falsely
triggering aNotInsertedYet==true in nsRange::CharacterDataChanged:
http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsRange.cpp#556
because I should have used GetNodeParent(), not GetParent(). Bah!
Try results pending:
https://tbpl.mozilla.org/?tree=Try&rev=5b0e7f840554
Assignee: nobody → matspal
OS: Mac OS X → All
Hardware: x86_64 → All
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #585853 -
Flags: review?(bugs)
Assignee | ||
Comment 4•13 years ago
|
||
Updated•13 years ago
|
Attachment #585853 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cddeb9fcc249
https://hg.mozilla.org/mozilla-central/rev/db09603b4186
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•