715098 - nsICacheMetadata::visitMetaData blows up in debug mode if the visitor returns false

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[:Gijs (he/him)]

http://mxr.mozilla.org/mozilla-central/source/netwerk/cache/nsCacheMetaData.cpp?rev=e7854b4d29ba#181

181     NS_ABORT_IF_FALSE(data == limit, "Metadata corrupted");

But data != limit whenever the visitor returns false. The documentation doesn't specify when that should happen (just that it returns a boolean).

Firebug currently uses this code and returns false, which crashes debug builds. I don't really know what the original goal of the assert was, but from what I can tell it can be removed.

Comment 1

[:Gijs (he/him)]

Attachment: Option 1: Remove the assert

One thing we could do is nuke the assert...

Comment 2

[:Gijs (he/him)]

Attachment: Option 2: Return early

Or we could keep the assert and return early.

NB: this returns NS_OK even if the visitor code fails. Whether that's desirable is up to you guys...

Comment 3

[Jason Duell]

Comment on attachment 585705 [details] [diff] [review]
Option 1: Remove the assert

Review of attachment 585705 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patches, Gijs!

Michal is a better reviewer for them.

Comment 4

[:Gijs (he/him)]

Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/2c215e31b7d0

Comment 5

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/2c215e31b7d0