71511 - clean up nsIGlobalHistory

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect, P3)

Description

[Judson Valeski]

It's an implementation detail that should not live in a public iface.

Comment 1

[Alec Flett]

Can't I just make this a dupe of 71482? :)

Comment 2

[Alec Flett]

eh, screw it. I have an API fix that I'm going to roll into this.

Comment 3

[Alec Flett]

Attachment: clean up addPage(), move setPageTitle() to nsIBrowserHistory

Comment 4

[Alec Flett]

I'll clean up the comment for isVisited()

I removed the whole referrer thing because nobody seems to actually use it (yet)
at some point we'll probably set that information at the same time we set the 
page title, so for now I'll leave it alone in the database.

Comment 5

[Judson Valeski]

nice! r=valeski.

Comment 6

[Judson Valeski]

actually, r=valeski after a comment on IsVisited(). Maybe point it back to
AddPage() w/ something like.

IsVisited() returns TRUE if a page had been passed into AddPage(). If the string
passed into IsVisited was never passed into AddPage(), return FALSE.

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

sr=shaver

Comment 8

[Alec Flett]

oops, I forgot that checked this in.

Comment 9

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]