715164 - ArrayIndexOutOfBoundsException in advanceBounce()

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

From a build that already has cset 08599b3e8590

E/GeckoApp(10888): java.lang.ArrayIndexOutOfBoundsException: length=16; index=-1
E/GeckoApp(10888):      at org.mozilla.gecko.ui.PanZoomController$BounceRunnable.advanceBounce(PanZoomController.java:629)
E/GeckoApp(10888):      at org.mozilla.gecko.ui.PanZoomController$BounceRunnable.run(PanZoomController.java:616)
E/GeckoApp(10888):      at android.os.Handler.handleCallback(Handler.java:605)
E/GeckoApp(10888):      at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoApp(10888):      at android.os.Looper.loop(Looper.java:137)
E/GeckoApp(10888):      at org.mozilla.gecko.GeckoApp$33.run(GeckoApp.java:1526)
E/GeckoApp(10888):      at android.os.Handler.handleCallback(Handler.java:605)
E/GeckoApp(10888):      at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoApp(10888):      at android.os.Looper.loop(Looper.java:137)
E/GeckoApp(10888):      at android.app.ActivityThread.main(ActivityThread.java:4424)
E/GeckoApp(10888):      at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoApp(10888):      at java.lang.reflect.Method.invoke(Method.java:511)
E/GeckoApp(10888):      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
E/GeckoApp(10888):      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
E/GeckoApp(10888):      at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Guard against yet another possible race

This race is a product of the animation timer turning around and posting things to the UI thread. This means that even if the animation timer is cancelled, there may be a runnable already scheduled on the UI thread.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 585780 [details] [diff] [review]
Guard against yet another possible race

Actually the FlingRunnable suffers from this too. I'll have a more generic patch up shortly.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Stop queued runnables from running after animation timer is cancelled

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Try run was green: https://tbpl.mozilla.org/?tree=Try&rev=a39024138e30

I'm also seeing this exception come up pretty often while hammering on robotium stuff, so it would be good to get this in before robotium is hooked up.

Comment 5

[Patrick Walton (:pcwalton)]

Comment on attachment 585820 [details] [diff] [review]
Stop queued runnables from running after animation timer is cancelled

Review of attachment 585820 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 6

[Patrick Walton (:pcwalton)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/91a8e4c55adb

Comment 7

[Patrick Walton (:pcwalton)]

Merged to mozilla-central early per QA request. This is crashing several devices on startup.

Note to sheriff: This will possibly cause a conflict; the inbound patch is identical to this one and can be dropped.

http://hg.mozilla.org/mozilla-central/rev/c7e27452a143

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Nexus S, 20120106, Flash 11

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 585820 [details] [diff] [review]
Stop queued runnables from running after animation timer is cancelled

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: Fennec crashes with ArrayIndexOutOfBoundsException
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Other regressions with pan/zoom behaviour. I wouldn't consider it high risk since the change is mostly rearranging code and adding guards.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 585820 [details] [diff] [review]
Stop queued runnables from running after animation timer is cancelled

[Triage Comment]
Mobile only - approved for Aurora

Comment 11

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/77855ed1e430