715204 - Non-ascii titles are displayed as garbage during session restore

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Mike Hommey [:glandium]]

Attachment: Title as mojibake

STR:
- Go to http://ja.m.wikipedia.org/wiki/%E3%83%9E%E3%83%89%E3%83%AC%E3%83%BC%E3%83%8C%E5%AF%BA%E9%99%A2
- Start other applications such that Nightly is OOM killed
- Start Nightly.

What happens:
- Title is shown in japanese.
- Title is then shown as mojibake.
- Title is shown in japanese again.

I'll be attaching screenshots for 2 and 3.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Title in japanese

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

readInputStreamToString handles us-ascii.  We should use 3rd option to read as UTF-8.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 589418 [details] [diff] [review]
fix

Looks fine to me.

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fd3d6234686

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/1fd3d6234686

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 589418 [details] [diff] [review]
fix

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Unicode chars not rendered correctly
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
very low, just specifies the encoding

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 589418 [details] [diff] [review]
fix

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ba758404a5ad

Comment 9

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-02-27)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.2