Remove Web Apps shortcut intent from allowing one to add the Android widget

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: sriram)

Tracking

Trunk
Firefox 13
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 fixed, fennec11+)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
As far as I know you can't install Web Apps in Nightly/Aurora, but you can add the $BRAND Web Apps widget to ones home-screen. Until the support is added, this should probably be hidden or removed.
(Reporter)

Comment 1

5 years ago
(When you attempt to add the widget you'll get a message, "No Web Apps Found")
Assignee: nobody → mark.finkle
tracking-fennec: --- → 11+
Priority: -- → P2
(Reporter)

Comment 2

5 years ago
@wesj, I guess just <activity android:name="LauncherShortcuts"></activity>
Assignee: mark.finkle → sriram
(Assignee)

Comment 3

5 years ago
Does this need "removal" of all corresponding code? Or just "hiding" the "Fennec Web Apps" in android widget section?
Fabrice - Does the future of WebApps use the same kind of code as we currently have? If not we could remove it all. If it will be similar, we could just remove the minimum needed to hide the widget.
Yes, there will be the same kind of API available from js. Hiding the widget looks like a good solution for now.
(In reply to Fabrice Desré [:fabrice] from comment #5)
> Yes, there will be the same kind of API available from js. Hiding the widget
> looks like a good solution for now.

Sriram - Sounds like a plan
(Assignee)

Comment 7

5 years ago
Created attachment 593245 [details] [diff] [review]
Patch

Hiding the Activity in AndroidManifest so that this can be re-used later when supported.
Attachment #593245 - Flags: review?(mark.finkle)
Attachment #593245 - Flags: review?(mark.finkle) → review+
(Reporter)

Updated

5 years ago
status-firefox13: --- → affected
Keywords: checkin-needed
(Assignee)

Comment 8

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/55f7963473f3
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Reporter)

Updated

5 years ago
Whiteboard: [inbound]

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/55f7963473f3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
(Assignee)

Comment 10

5 years ago
Comment on attachment 593245 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
User will see a Fennec widget in "Widgets" section of the device. However he will not be able to add any.

Testing completed (on m-c, etc.): Landed on m-c on 02/01

Risk to taking this patch (and alternatives if risky):
None. This just hides exposing the widget.

String changes made by this patch:
None.
Attachment #593245 - Flags: approval-mozilla-beta?
Attachment #593245 - Flags: approval-mozilla-aurora?

Updated

5 years ago
status-firefox13: affected → ---
Comment on attachment 593245 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593245 - Flags: approval-mozilla-beta?
Attachment #593245 - Flags: approval-mozilla-beta+
Attachment #593245 - Flags: approval-mozilla-aurora?
Attachment #593245 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/f010ed04ac8d
status-firefox12: affected → fixed
status-firefox13: --- → fixed
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 13

5 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/841c659c14d8
(Reporter)

Updated

5 years ago
status-firefox11: affected → fixed
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.