715260 - Remove Web Apps shortcut intent from allowing one to add the Android widget

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Aaron Train [:aaronmt]]

As far as I know you can't install Web Apps in Nightly/Aurora, but you can add the $BRAND Web Apps widget to ones home-screen. Until the support is added, this should probably be hidden or removed.

Comment 1

[Aaron Train [:aaronmt]]

(When you attempt to add the widget you'll get a message, "No Web Apps Found")

Comment 2

[Aaron Train [:aaronmt]]

@wesj, I guess just <activity android:name="LauncherShortcuts"></activity>

Comment 3

[Sriram Ramasubramanian [:sriram]]

Does this need "removal" of all corresponding code? Or just "hiding" the "Fennec Web Apps" in android widget section?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Fabrice - Does the future of WebApps use the same kind of code as we currently have? If not we could remove it all. If it will be similar, we could just remove the minimum needed to hide the widget.

Comment 5

[[:fabrice] Fabrice Desré]

Yes, there will be the same kind of API available from js. Hiding the widget looks like a good solution for now.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Fabrice Desré [:fabrice] from comment #5)
> Yes, there will be the same kind of API available from js. Hiding the widget
> looks like a good solution for now.

Sriram - Sounds like a plan

Comment 7

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Hiding the Activity in AndroidManifest so that this can be re-used later when supported.

Comment 8

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/55f7963473f3

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/55f7963473f3

Comment 10

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 593245 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
User will see a Fennec widget in "Widgets" section of the device. However he will not be able to add any.

Testing completed (on m-c, etc.): Landed on m-c on 02/01

Risk to taking this patch (and alternatives if risky):
None. This just hides exposing the widget.

String changes made by this patch:
None.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 593245 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f010ed04ac8d

Comment 13

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-beta/rev/841c659c14d8