Closed Bug 715260 Opened 8 years ago Closed 8 years ago

Remove Web Apps shortcut intent from allowing one to add the Android widget

Categories

(Firefox for Android :: General, defect, P2)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 13
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
firefox13 --- fixed
fennec 11+ ---

People

(Reporter: aaronmt, Assigned: sriram)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

As far as I know you can't install Web Apps in Nightly/Aurora, but you can add the $BRAND Web Apps widget to ones home-screen. Until the support is added, this should probably be hidden or removed.
(When you attempt to add the widget you'll get a message, "No Web Apps Found")
Assignee: nobody → mark.finkle
tracking-fennec: --- → 11+
Priority: -- → P2
@wesj, I guess just <activity android:name="LauncherShortcuts"></activity>
Assignee: mark.finkle → sriram
Does this need "removal" of all corresponding code? Or just "hiding" the "Fennec Web Apps" in android widget section?
Fabrice - Does the future of WebApps use the same kind of code as we currently have? If not we could remove it all. If it will be similar, we could just remove the minimum needed to hide the widget.
Yes, there will be the same kind of API available from js. Hiding the widget looks like a good solution for now.
(In reply to Fabrice Desré [:fabrice] from comment #5)
> Yes, there will be the same kind of API available from js. Hiding the widget
> looks like a good solution for now.

Sriram - Sounds like a plan
Attached patch PatchSplinter Review
Hiding the Activity in AndroidManifest so that this can be re-used later when supported.
Attachment #593245 - Flags: review?(mark.finkle)
Attachment #593245 - Flags: review?(mark.finkle) → review+
Keywords: checkin-needed
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/55f7963473f3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 593245 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
User will see a Fennec widget in "Widgets" section of the device. However he will not be able to add any.

Testing completed (on m-c, etc.): Landed on m-c on 02/01

Risk to taking this patch (and alternatives if risky):
None. This just hides exposing the widget.

String changes made by this patch:
None.
Attachment #593245 - Flags: approval-mozilla-beta?
Attachment #593245 - Flags: approval-mozilla-aurora?
Comment on attachment 593245 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593245 - Flags: approval-mozilla-beta?
Attachment #593245 - Flags: approval-mozilla-beta+
Attachment #593245 - Flags: approval-mozilla-aurora?
Attachment #593245 - Flags: approval-mozilla-aurora+
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.