Closed
Bug 715275
Opened 13 years ago
Closed 13 years ago
No favicon / default favicon image is very fuzzy
Categories
(Firefox for Android Graveyard :: General, defect, P4)
Tracking
(firefox11 fixed, firefox12 verified)
VERIFIED
FIXED
Firefox 12
People
(Reporter: padamczyk, Assigned: mbrubeck)
Details
Attachments
(3 files)
|
159.38 KB,
image/png
|
Details | |
|
10.57 KB,
application/zip
|
Details | |
|
11.16 KB,
patch
|
sriram
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Fuzzy icon example
Higher quality / multiple image sizes of the no favicon / default favicon are needed.
|
||
Updated•13 years ago
|
Assignee: nobody → padamczyk
Priority: -- → P4
|
Reporter | |
Comment 1•13 years ago
|
||
|
||
Updated•13 years ago
|
Assignee: nobody → mbrubeck
|
Assignee | |
Comment 3•13 years ago
|
||
Sorry for taking a while to get to this, Patryk. This bug adds new default favicon images at the following sizes as used in the awesomescreen:
MDPI: 32px
HDPI: 48px
XHDPI: 64px
The favicon in the URL bar is drawn at a smaller size (21.33dp, which maps to the pixel sizes below). Currently it is just a scaled-down version of the default favicon. If you'd like to provide a separate image for the smaller URL bar icon, it should be at the following sizes:
MDPI: 21px
HDPI: 32px (we already have an icon available at this size)
XHDPI: 43px (I think - can someone with an XHDPI device test this?)
Attachment #591603 -
Flags: review?(sriram)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 591603 [details] [diff] [review]
patch
Review of attachment 591603 [details] [diff] [review]:
-----------------------------------------------------------------
The patch looks fine to me.
I haven't tested it yet though.
Attachment #591603 -
Flags: review?(sriram) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: NEW → ASSIGNED
status-firefox11:
--- → affected
status-firefox12:
--- → fixed
Target Milestone: --- → Firefox 12
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 591603 [details] [diff] [review]
patch
[Approval Request Comment]
Trivial Android-only change to tweak some image files. Fixes some fuzzily-scaled images in the UI.
Attachment #591603 -
Flags: approval-mozilla-aurora?
|
||
Comment 7•13 years ago
|
||
Comment on attachment 591603 [details] [diff] [review]
patch
[Triage Comment]
Mobile only - approved for Aurora.
Attachment #591603 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 9•13 years ago
|
||
This. Is. Lovely.
Verified Fixed on M-C
Samsung Galaxy Nexus (Android 4.0.3)
20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623
Aurora nom?
Status: RESOLVED → VERIFIED
OS: Mac OS X → Android
Hardware: x86 → ARM
|
|
Assignee | |
Comment 10•13 years ago
|
||
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•