Closed Bug 715326 Opened 8 years ago Closed 8 years ago

Loading about:config initially via adb shell shows zoomed-in viewport

Categories

(Firefox for Android :: General, defect, P1)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
fennec 11+ ---

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(4 files)

STR: (same as bug 714972)

1) adb shell am start -a android.intent.action.VIEW -n org.mozilla.fennec/.App about:fennec
2) adb shell am start -a android.intent.action.MAIN -c android.intent.category.HOME
3) adb shell /data/local/oom-fennec
4) adb shell am start -a android.intent.action.VIEW -n org.mozilla.fennec/.App about:config

On the first step about:fennec loads with an unexpected viewport.
After step 4 about:config renders with a perma-checkerboard and a bad viewport. Log attached.
tracking-fennec: --- → 11+
Priority: -- → P1
Bug 708746 fixed part of the problem here by initializing the java viewport page-size parameters to something more reasonable.
Depends on: 708746
Attachment #587707 - Flags: review?(pwalton) → review+
Comment on attachment 587708 [details] [diff] [review]
(2/2) Better focus when scaling up page smaller than viewport on both axes

Review of attachment 587708 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I wonder if we should be zooming out to make page *height* (as opposed to page width) fill the screen at all. Seems like it's asking for trouble to do so, because page height tends to start very small when loading pages.
Attachment #587708 - Flags: review?(pwalton) → review+
(In reply to Patrick Walton (:pcwalton) from comment #5)
> Looks good, but I wonder if we should be zooming out to make page *height*
> (as opposed to page width) fill the screen at all. Seems like it's asking
> for trouble to do so, because page height tends to start very small when
> loading pages.

Good point. The code I added in bug 710297 might be simplified if we were to do that - we might not need to check the page size against the gScreen(Width|Height). I'm wondering if there are conditions where the page size can be forced to be smaller than viewport size though; if that's the case then the current approach is better since browser.js will send the page size update once the readyState flips over to complete.
Target Milestone: --- → Firefox 12
Comment on attachment 587707 [details] [diff] [review]
(1/2) Don't round page size sending from JS to java

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: size of rendered page could be off by up to a couple of pixels from where it should be
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk
Attachment #587707 - Flags: approval-mozilla-aurora?
Comment on attachment 587708 [details] [diff] [review]
(2/2) Better focus when scaling up page smaller than viewport on both axes

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: sometimes, on pages smaller than the viewport, the page will be scrolled to the end on one axis
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): possible misplacement of the page during zoom operations
Attachment #587708 - Flags: approval-mozilla-aurora?
Comment on attachment 587707 [details] [diff] [review]
(1/2) Don't round page size sending from JS to java

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #587707 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #587708 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.