715326 - Loading about:config initially via adb shell shows zoomed-in viewport

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Logcat from about:fennec

STR: (same as bug 714972)

1) adb shell am start -a android.intent.action.VIEW -n org.mozilla.fennec/.App about:fennec
2) adb shell am start -a android.intent.action.MAIN -c android.intent.category.HOME
3) adb shell /data/local/oom-fennec
4) adb shell am start -a android.intent.action.VIEW -n org.mozilla.fennec/.App about:config

On the first step about:fennec loads with an unexpected viewport.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: logcat from about:config

After step 4 about:config renders with a perma-checkerboard and a bad viewport. Log attached.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Bug 708746 fixed part of the problem here by initializing the java viewport page-size parameters to something more reasonable.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Don't round page size sending from JS to java

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Better focus when scaling up page smaller than viewport on both axes

Comment 5

[Patrick Walton (:pcwalton)]

Comment on attachment 587708 [details] [diff] [review]
(2/2) Better focus when scaling up page smaller than viewport on both axes

Review of attachment 587708 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I wonder if we should be zooming out to make page *height* (as opposed to page width) fill the screen at all. Seems like it's asking for trouble to do so, because page height tends to start very small when loading pages.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Patrick Walton (:pcwalton) from comment #5)
> Looks good, but I wonder if we should be zooming out to make page *height*
> (as opposed to page width) fill the screen at all. Seems like it's asking
> for trouble to do so, because page height tends to start very small when
> loading pages.

Good point. The code I added in bug 710297 might be simplified if we were to do that - we might not need to check the page size against the gScreen(Width|Height). I'm wondering if there are conditions where the page size can be forced to be smaller than viewport size though; if that's the case then the current approach is better since browser.js will send the page size update once the readyState flips over to complete.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc2e0fc688c6
https://hg.mozilla.org/integration/mozilla-inbound/rev/a18c8d5765ea

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/fc2e0fc688c6
https://hg.mozilla.org/mozilla-central/rev/a18c8d5765ea

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 587707 [details] [diff] [review]
(1/2) Don't round page size sending from JS to java

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: size of rendered page could be off by up to a couple of pixels from where it should be
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 587708 [details] [diff] [review]
(2/2) Better focus when scaling up page smaller than viewport on both axes

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: sometimes, on pages smaller than the viewport, the page will be scrolled to the end on one axis
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): possible misplacement of the page during zoom operations

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 587707 [details] [diff] [review]
(1/2) Don't round page size sending from JS to java

[Triage Comment]
Mobile only - approved for Aurora.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a97a73096b0c
https://hg.mozilla.org/releases/mozilla-aurora/rev/bb8d14637ea5