Eliminate getPrincipalArray and globalPrivilegesEnabled from JSPrincipals

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

They don't do anything useful, and haven't as long as hg has been around. They consume memory, and fool poor people like myself into thinking there's something plurals about a JSPrincipals.

Patch coming right up. I'd also love to rename JSPrincipals to JSPrincipal, but I'm guessing that will be vetoed on the grounds that it breaks the API for no good reason. _I_ say it's a good reason.

https://developer.mozilla.org/en/JSPrincipals will also need to be updated.
Created attachment 585968 [details] [diff] [review]
Eliminate getPrincipalArray and globalPrivilegesEnabled from JSPrincipals. v1

Attaching patch. Flagging mrbkap for review.
Attachment #585968 - Flags: review?(mrbkap)
Comment on attachment 585968 [details] [diff] [review]
Eliminate getPrincipalArray and globalPrivilegesEnabled from JSPrincipals. v1

Yeah, we should have done this when we started making backwards-incompatible changes to the UI.
Attachment #585968 - Flags: review?(mrbkap) → review+
Of course, by UI I meant API.
Pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=4077fdcc109e
Linux built super-fast for this one and went green, which is good enough for me.

Landed to mozilla-inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/a761ff40306b
Target Milestone: --- → mozilla12

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a761ff40306b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.