715417 - Eliminate getPrincipalArray and globalPrivilegesEnabled from JSPrincipals

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bobby Holley (:bholley)]

They don't do anything useful, and haven't as long as hg has been around. They consume memory, and fool poor people like myself into thinking there's something plurals about a JSPrincipals.

Patch coming right up. I'd also love to rename JSPrincipals to JSPrincipal, but I'm guessing that will be vetoed on the grounds that it breaks the API for no good reason. _I_ say it's a good reason.

https://developer.mozilla.org/en/JSPrincipals will also need to be updated.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Eliminate getPrincipalArray and globalPrivilegesEnabled from JSPrincipals. v1

Attaching patch. Flagging mrbkap for review.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 585968 [details] [diff] [review]
Eliminate getPrincipalArray and globalPrivilegesEnabled from JSPrincipals. v1

Yeah, we should have done this when we started making backwards-incompatible changes to the UI.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Of course, by UI I meant API.

Comment 4

[Bobby Holley (:bholley)]

Pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=4077fdcc109e

Comment 5

[Bobby Holley (:bholley)]

Linux built super-fast for this one and went green, which is good enough for me.

Landed to mozilla-inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/a761ff40306b

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a761ff40306b