Closed
Bug 715513
Opened 13 years ago
Closed 13 years ago
[Azure] Implement text in Cairo backend
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: joe, Assigned: joe)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
12.24 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
700 bytes,
patch
|
Details | Diff | Splinter Review |
This patch implements text in the Canvas backend, both filled and text-to-path. In a build with the other patches implementing the Cairo backend as well as this patch, we still don't use this code, though, because on OS X we unconditionally do Skia fonts for ScaledFont. We'll need to resolve this problem before we can use this backend.
Attachment #586092 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 1•13 years ago
|
||
This patch overrides OS X using Skia ScaledFonts by default, so this patch can actually be tested.
Assignee: nobody → joe
Comment 2•13 years ago
|
||
(In reply to Joe Drew (:JOEDREW!) from comment #0)
> Created attachment 586092 [details] [diff] [review]
> font support
>
> This patch implements text in the Canvas backend, both filled and
> text-to-path. In a build with the other patches implementing the Cairo
> backend as well as this patch, we still don't use this code, though, because
> on OS X we unconditionally do Skia fonts for ScaledFont. We'll need to
> resolve this problem before we can use this backend.
I plan on resolving this as part of the CG backend landing.
Comment 3•13 years ago
|
||
Comment on attachment 586092 [details] [diff] [review]
font support
Review of attachment 586092 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/Types.h
@@ +95,5 @@
> NATIVE_FONT_DWRITE_FONT_FACE,
> NATIVE_FONT_GDI_FONT_FACE,
> NATIVE_FONT_MAC_FONT_FACE,
> + NATIVE_FONT_SKIA_FONT_FACE,
> + NATIVE_FONT_GFX_FONT_FACE
NATIVE_FONT_CAIRO_FONT_FACE is preferred.
Attachment #586092 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•