The default bug view has changed. See this FAQ.

[Azure] Implement text in Cairo backend

RESOLVED FIXED in mozilla12

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Joe Drew (not getting mail))

Tracking

(Blocks: 1 bug)

Trunk
mozilla12
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 586092 [details] [diff] [review]
font support

This patch implements text in the Canvas backend, both filled and text-to-path. In a build with the other patches implementing the Cairo backend as well as this patch, we still don't use this code, though, because on OS X we unconditionally do Skia fonts for ScaledFont. We'll need to resolve this problem before we can use this backend.
Attachment #586092 - Flags: review?(jmuizelaar)
(Assignee)

Comment 1

5 years ago
Created attachment 586093 [details] [diff] [review]
override skia fonts

This patch overrides OS X using Skia ScaledFonts by default, so this patch can actually be tested.
Assignee: nobody → joe
(In reply to Joe Drew (:JOEDREW!) from comment #0)
> Created attachment 586092 [details] [diff] [review]
> font support
> 
> This patch implements text in the Canvas backend, both filled and
> text-to-path. In a build with the other patches implementing the Cairo
> backend as well as this patch, we still don't use this code, though, because
> on OS X we unconditionally do Skia fonts for ScaledFont. We'll need to
> resolve this problem before we can use this backend.

I plan on resolving this as part of the CG backend landing.
Comment on attachment 586092 [details] [diff] [review]
font support

Review of attachment 586092 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Types.h
@@ +95,5 @@
>    NATIVE_FONT_DWRITE_FONT_FACE,
>    NATIVE_FONT_GDI_FONT_FACE,
>    NATIVE_FONT_MAC_FONT_FACE,
> +  NATIVE_FONT_SKIA_FONT_FACE,
> +  NATIVE_FONT_GFX_FONT_FACE

NATIVE_FONT_CAIRO_FONT_FACE is preferred.
Attachment #586092 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/603df6854a52
https://hg.mozilla.org/mozilla-central/rev/603df6854a52
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.