Closed Bug 715513 Opened 8 years ago Closed 8 years ago

[Azure] Implement text in Cairo backend

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: joe, Assigned: joe)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached patch font supportSplinter Review
This patch implements text in the Canvas backend, both filled and text-to-path. In a build with the other patches implementing the Cairo backend as well as this patch, we still don't use this code, though, because on OS X we unconditionally do Skia fonts for ScaledFont. We'll need to resolve this problem before we can use this backend.
Attachment #586092 - Flags: review?(jmuizelaar)
This patch overrides OS X using Skia ScaledFonts by default, so this patch can actually be tested.
Assignee: nobody → joe
(In reply to Joe Drew (:JOEDREW!) from comment #0)
> Created attachment 586092 [details] [diff] [review]
> font support
> 
> This patch implements text in the Canvas backend, both filled and
> text-to-path. In a build with the other patches implementing the Cairo
> backend as well as this patch, we still don't use this code, though, because
> on OS X we unconditionally do Skia fonts for ScaledFont. We'll need to
> resolve this problem before we can use this backend.

I plan on resolving this as part of the CG backend landing.
Comment on attachment 586092 [details] [diff] [review]
font support

Review of attachment 586092 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Types.h
@@ +95,5 @@
>    NATIVE_FONT_DWRITE_FONT_FACE,
>    NATIVE_FONT_GDI_FONT_FACE,
>    NATIVE_FONT_MAC_FONT_FACE,
> +  NATIVE_FONT_SKIA_FONT_FACE,
> +  NATIVE_FONT_GFX_FONT_FACE

NATIVE_FONT_CAIRO_FONT_FACE is preferred.
Attachment #586092 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/603df6854a52
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.