Closed Bug 715543 Opened 9 years ago Closed 9 years ago

Fix the debugger after the latest merge from fx-team

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: past, Assigned: past)

References

Details

Attachments

(1 file, 2 obsolete files)

After the merge from fx-team in changeset bf0bae1ca857 the debugger does not start and tests fail.
Attached patch WIP (obsolete) — Splinter Review
With the attached patch the debugger works, but one test still fails:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_script-switching.js | The correct script was loaded initially.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_script-switching.js | The second script is displayed again.

This seems to be caused because the scripts are only partially loaded in the editor, like in bug 713359.
Assignee: nobody → past
Attached patch Working patch (obsolete) — Splinter Review
Fixed the last failing test, by using the fix from bug 713359. Also made the test more robust, by determining script loaded status using SourceEditor events.
Attachment #586114 - Attachment is obsolete: true
Attachment #587011 - Flags: review?(dcamp)
Attached patch Working patch v2Splinter Review
Fixed another bug I found during testing, caused by the recently added Debugger.Environment.
Attachment #587011 - Attachment is obsolete: true
Attachment #587011 - Flags: review?(dcamp)
Attachment #587022 - Flags: review?(dcamp)
Attachment #587022 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/fe6aff0ff43a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.