715543 - Fix the debugger after the latest merge from fx-team

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

After the merge from fx-team in changeset bf0bae1ca857 the debugger does not start and tests fail.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: WIP

With the attached patch the debugger works, but one test still fails:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_script-switching.js | The correct script was loaded initially.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_script-switching.js | The second script is displayed again.

This seems to be caused because the scripts are only partially loaded in the editor, like in bug 713359.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch

Fixed the last failing test, by using the fix from bug 713359. Also made the test more robust, by determining script loaded status using SourceEditor events.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch v2

Fixed another bug I found during testing, caused by the recently added Debugger.Environment.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/fe6aff0ff43a