Fix the debugger after the latest merge from fx-team

RESOLVED FIXED

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

After the merge from fx-team in changeset bf0bae1ca857 the debugger does not start and tests fail.
Created attachment 586114 [details] [diff] [review]
WIP

With the attached patch the debugger works, but one test still fails:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_script-switching.js | The correct script was loaded initially.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_script-switching.js | The second script is displayed again.

This seems to be caused because the scripts are only partially loaded in the editor, like in bug 713359.
Assignee: nobody → past
Created attachment 587011 [details] [diff] [review]
Working patch

Fixed the last failing test, by using the fix from bug 713359. Also made the test more robust, by determining script loaded status using SourceEditor events.
Attachment #586114 - Attachment is obsolete: true
Attachment #587011 - Flags: review?(dcamp)
Created attachment 587022 [details] [diff] [review]
Working patch v2

Fixed another bug I found during testing, caused by the recently added Debugger.Environment.
Attachment #587011 - Attachment is obsolete: true
Attachment #587011 - Flags: review?(dcamp)
Attachment #587022 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #587022 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/fe6aff0ff43a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.