71561 - dropdown SELECTs without scrollbars have unpainted area

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

There seems to be a regression in dropdown SELECT widgets due to
attinasi's checkin last night (nsCSSStyleSheet.cpp, revision
3.145).For SELECT widgets that shouldn't have a scrollbar (i.e.,
they have a short list of OPTIONs), there's now some garbage as
if the widgets are expecting a scrollbar to be there.

See some of the widgets in the middle section of
http://www.dn.se/pastan/jsp/Crosslink.jsp?d=1002
for an example.

I'm seeing this on Linux and hwaara is seeing it on Windows 98.

hwaara says it's also visible on
http://bugzilla.mozilla.org/reports.cgi

I'm also seeing that the background on an OPTION in dropdown
SELECTs is painted only over the text rather than the width of
the SELECT, and that same area is the only part responding to
mouse actions.  I didn't test that that's also caused by the
same checkin but it certainly wouldn't surprise me.  (I'm
seeing this problem on the form in which I'm entering this
bug.)

Comment 1

[Håkan Waara]

Another regression seems to be that the text/caption inside the dropdown is
painted too near the left end of the dropdown.

Comment 2

[R.K.Aa.]

text too far to the left reported in bug 71593

Comment 3

[Marc Attinasi]

My checkin was for bug 56117

Hmm. So, why is preventing text nodes from getting into selector matches causing 
issues with selects? Could there be an element that implements nsITextContent 
and needs to have selector matching done on it? I'll investigate - thanks for 
the report!

Comment 4

[Marc Attinasi]

I think I see it now.

http://lxr.mozilla.org/seamonkey/source/layout/html/forms/src/nsComboboxControlF
rame.cpp#2224

Comboboxes use a text element and resolve style for it using the 
:-moz-display-comboboxcontrol-frame pseudo.

It looks like it was a bad idea to assume that all implementors of 
nsITextContent are textNodes that never need to be styled. I'm guessing I'll 
have to back that change out - I apologize for not catching that.

Comment 5

[Marc Attinasi]

Change to nsCSSStyleSheet.cpp backed out. Again, my apologies.

Comment 6

[Vladimir Ermakov]

Verifying on:
 2001-03-29-04-Mtrunk Windows 98
 2001-03-29-08-Mtrunk RedHat Linux 6.2
 2001-03-29-08-Mtrunk MacOS 8.x