715615 - nsHTMLTableElement CC handling is suspicious

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

nsHTMLTableElement doesn't unlink mTBodies nor mRows,
and mRows doesn't unlink mOrphanRows.

I haven't figured out whether there can a real leak somewhere, but I've
seen few CC logs where table element keeps a DOM tree alive and table element
has one unknown edge to it.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

And to clarify, I haven't seen shutdown leaks, but only suspicious CC logs.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

There should be null checks for all the unlinked variables.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 586495 [details] [diff] [review]
patch

r=me

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/0e46065c6d9f