nsHTMLTableElement CC handling is suspicious

RESOLVED FIXED

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

12 Branch
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
nsHTMLTableElement doesn't unlink mTBodies nor mRows,
and mRows doesn't unlink mOrphanRows.

I haven't figured out whether there can a real leak somewhere, but I've
seen few CC logs where table element keeps a DOM tree alive and table element
has one unknown edge to it.
(Assignee)

Comment 1

6 years ago
And to clarify, I haven't seen shutdown leaks, but only suspicious CC logs.
(Assignee)

Comment 2

6 years ago
Created attachment 586495 [details] [diff] [review]
patch

There should be null checks for all the unlinked variables.
Assignee: nobody → bugs
Attachment #586495 - Flags: review?(bzbarsky)

Comment 3

6 years ago
Comment on attachment 586495 [details] [diff] [review]
patch

r=me
Attachment #586495 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/0e46065c6d9f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.