Last Comment Bug 715615 - nsHTMLTableElement CC handling is suspicious
: nsHTMLTableElement CC handling is suspicious
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: 12 Branch
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 12:06 PST by Olli Pettay [:smaug]
Modified: 2012-01-07 15:47 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.19 KB, patch)
2012-01-06 11:35 PST, Olli Pettay [:smaug]
bzbarsky: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2012-01-05 12:06:28 PST
nsHTMLTableElement doesn't unlink mTBodies nor mRows,
and mRows doesn't unlink mOrphanRows.

I haven't figured out whether there can a real leak somewhere, but I've
seen few CC logs where table element keeps a DOM tree alive and table element
has one unknown edge to it.
Comment 1 Olli Pettay [:smaug] 2012-01-05 12:55:44 PST
And to clarify, I haven't seen shutdown leaks, but only suspicious CC logs.
Comment 2 Olli Pettay [:smaug] 2012-01-06 11:35:02 PST
Created attachment 586495 [details] [diff] [review]
patch

There should be null checks for all the unlinked variables.
Comment 3 Boris Zbarsky [:bz] 2012-01-06 21:51:32 PST
Comment on attachment 586495 [details] [diff] [review]
patch

r=me
Comment 4 Olli Pettay [:smaug] 2012-01-07 15:47:24 PST
http://hg.mozilla.org/mozilla-central/rev/0e46065c6d9f

Note You need to log in before you can comment on or make changes to this bug.