715619 - FirefoxNightly needs a space in it

Status: NEW

(Firefox :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The current name of FirefoxNightly looks silly without the space between Firefox and Nightly.

Comment 1

[Justin Dolske [:Dolske]]

This got noted in bug 696436. AFAIK limi hasn't filed a new one, so let's use this bug!

I'll hand this to Gavin for the moment. But this should be as simple as just adding a space? Or was there concern about breaking build scripts?

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If you don't want to worry about breaking build scripts by changing the on-disk name, you can engineer a similar fix to what I did for the crash reporter back in the day (bug 382762).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Where exactly are you seeing "FirefoxNightly" and expecting to see "Firefox Nightly"? Dock? Looking at the app in Finder? Cmd+Tab switcher? Those all seems to use the bundle's filename rather than the actual bundle filename, for some reason. I see "Nightly" in the menu bar.

Really the only thing bug 696436 changed was the bundle filename (the plist strings are all still "Nightly"), so unless there's some additional plist name-override thingy we can use, I don't think we can fix this short of actually renaming the bundle. I don't know how likely that is to break things.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #3)
> Where exactly are you seeing "FirefoxNightly" and expecting to see "Firefox
> Nightly"? Dock?

Yes.

> Looking at the app in Finder?

Yes.

> Cmd+Tab switcher?

Yes.

> Those all
> seems to use the bundle's filename rather than the actual bundle filename,
> for some reason. I see "Nightly" in the menu bar.

As do I

> Really the only thing bug 696436 changed was the bundle filename (the plist
> strings are all still "Nightly"), so unless there's some additional plist
> name-override thingy we can use, I don't think we can fix this short of
> actually renaming the bundle. I don't know how likely that is to break
> things.

Won't it break the same way it broke when we changed it from Nightly to FirefoxNightly

Comment 5

[:Gavin Sharp [email: [e-mail]]]

The addition of a space in the file name is riskier, because it can break build scripts that don't expect spaces in the filename.