Last Comment Bug 715650 - User auto-completion does not work in request.cgi for requester and requestee as expected
: User auto-completion does not work in request.cgi for requester and requestee...
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Attachments & Requests (show other bugs)
: 4.0.3
: All All
: -- normal (vote)
: Bugzilla 4.0
Assigned To: David Lawrence [:dkl]
: default-qa
Mentors:
Depends on: 578254
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 13:30 PST by David Lawrence [:dkl]
Modified: 2012-01-10 22:02 PST (History)
2 users (show)
LpSolit: approval+
LpSolit: approval4.2+
LpSolit: blocking4.2-
LpSolit: approval4.0+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch to fix user autocompletion for request.cgi (v1) (593 bytes, patch)
2012-01-05 13:33 PST, David Lawrence [:dkl]
timello: review+
Details | Diff | Review

Description David Lawrence [:dkl] 2012-01-05 13:30:15 PST
When entering a partial username in request.cgi in either the requester or requestee, it should give a list of accounts to choose from like other user fields. This does not occur as the support for YUIs autocompletion is not being loaded by the template properly. 

Patching coming

dkl
Comment 1 David Lawrence [:dkl] 2012-01-05 13:33:21 PST
Created attachment 586201 [details] [diff] [review]
Patch to fix user autocompletion for request.cgi (v1)

Patch to fix user autocompletion for requester and requestee in request.cgi

dkl
Comment 2 Tiago Mello [:timello] 2012-01-05 13:36:53 PST
Comment on attachment 586201 [details] [diff] [review]
Patch to fix user autocompletion for request.cgi (v1)

Exactly what it was missing! Thanks!
Comment 3 Frédéric Buclin 2012-01-05 15:35:14 PST
Not a blocker, but it can land on all 4.x branches anyway. Bug 578254 never worked, even in 4.0 where it has first been implemented. Do I need to recall everyone (patch authors *and* reviewers) to *test* a patch, not just guess that the patch works?
Comment 4 David Lawrence [:dkl] 2012-01-10 22:02:14 PST
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified template/en/default/request/queue.html.tmpl
Committed revision 8070.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/4.2
modified template/en/default/request/queue.html.tmpl
Committed revision 8003.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/4.0
modified template/en/default/request/queue.html.tmpl
Committed revision 7681.

dkl

Note You need to log in before you can comment on or make changes to this bug.