715656 - js::StackFrame::markFunctionEpilogueDone to updateEpilogueFlags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Attachment: Rename js::StackFrame::markFunctionEpilogueDone to updateEpilogueFlags, to be less misleading

I was recently led astray by the call to markFunctionEpilogueDone in EnterMethodJIT. The name updateEpilogueFlags seems more accurate.

I expected markFunctionEpilogueDone to make the call to functionEpilogue in js::Interpret (after the jit_return: label) have no effect. But markFunctionEpilogueDone only clears the hasArgsObj and hasCallObj flags *if* the corresponding CallObject or ArgumentsObject have already been put: if the objects are still referring to their stack frames, then markFunctionEpilogueDone leaves the flags alone.

The name updateEpilogueFlags seems more accurate.

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 586211 [details] [diff] [review]
Rename js::StackFrame::markFunctionEpilogueDone to updateEpilogueFlags, to be less misleading

Nice.  I look forward to killing 'puttedness' altogether (bug 659577).

Comment 2

[Jim Blandy :jimb]

Pushed: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f0eab7fd20af
Try server run: https://tbpl.mozilla.org/?tree=Try&rev=bb47a4683611

Comment 3

[Jim Blandy :jimb]

This got landed in Mozilla-central a long time ago, but the bug didn't get closed.
https://hg.mozilla.org/mozilla-central/rev/f0eab7fd20af