Last Comment Bug 715656 - js::StackFrame::markFunctionEpilogueDone to updateEpilogueFlags
: js::StackFrame::markFunctionEpilogueDone to updateEpilogueFlags
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Jim Blandy :jimb
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 13:39 PST by Jim Blandy :jimb
Modified: 2012-05-08 17:24 PDT (History)
2 users (show)
jimb: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Rename js::StackFrame::markFunctionEpilogueDone to updateEpilogueFlags, to be less misleading (3.61 KB, patch)
2012-01-05 13:39 PST, Jim Blandy :jimb
luke: review+
Details | Diff | Review

Description Jim Blandy :jimb 2012-01-05 13:39:35 PST
Created attachment 586211 [details] [diff] [review]
Rename js::StackFrame::markFunctionEpilogueDone to updateEpilogueFlags, to be less misleading

I was recently led astray by the call to markFunctionEpilogueDone in EnterMethodJIT. The name updateEpilogueFlags seems more accurate.

I expected markFunctionEpilogueDone to make the call to functionEpilogue in js::Interpret (after the jit_return: label) have no effect. But markFunctionEpilogueDone only clears the hasArgsObj and hasCallObj flags *if* the corresponding CallObject or ArgumentsObject have already been put: if the objects are still referring to their stack frames, then markFunctionEpilogueDone leaves the flags alone.

The name updateEpilogueFlags seems more accurate.
Comment 1 Luke Wagner [:luke] 2012-01-05 15:10:34 PST
Comment on attachment 586211 [details] [diff] [review]
Rename js::StackFrame::markFunctionEpilogueDone to updateEpilogueFlags, to be less misleading

Nice.  I look forward to killing 'puttedness' altogether (bug 659577).
Comment 3 Jim Blandy :jimb 2012-05-08 17:24:13 PDT
This got landed in Mozilla-central a long time ago, but the bug didn't get closed.
https://hg.mozilla.org/mozilla-central/rev/f0eab7fd20af

Note You need to log in before you can comment on or make changes to this bug.