71566 - Win9x user-agent string code not forwards-compatibile

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The user-agent string code won't do very good things on versions of
Windows 9x that we don't already know.  We need to make it forwards-
ompatible so it prints something sensible for future OSes (although
I'm not sure whether future consumer OSes will report themselves as
NT...)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See:

http://msdn.microsoft.com/library/psdk/sysmgmt/sysinfo_49iw.htm
http://msdn.microsoft.com/library/psdk/sysmgmt/sysinfo_1o1e.htm
http://msdn.microsoft.com/library/psdk/sysmgmt/sysinfo_3a0i.htm
http://msdn.microsoft.com/library/wcedoc/wcesdkr/_wcesdk_win32_osversioninfo_str.htm

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: possible patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Should try to fix this in 0.9.2 so we don't end up setting a bad precedent when
the next version of windows comes out.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: updated patch (tested on NT 5.0)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simplified to avoid duplication of code

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: same thing, merged with changes from bug 85271

Comment 7

[Darin Fisher]

patch looks good to me r/sr=darin

Comment 8

[rpotts (gone)]

looks good to me. (sr=rpotts)

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

a=roc on behalf of drivers

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2001-06-19 15:40 PDT.

Comment 11

[John Unruh]

verified.